From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6697D3F44D6 for ; Mon, 17 Aug 2026 10:53:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786963996; cv=none; b=QiwcIJpKev0XeAP/zVVXRiy2dWd7aPaXm6bRJ+9AQeLnRwYgQ4Pc8A8Lub46cQB7pNZwUnSYCY/q7P6b8OeLHPy4Ya5m0/OMjQYADgPbZjpyHOtMlAqTUR424AF+e7VXbGwGMg00Bw5+9X5/69t/tvFqWRnQ2QbfbqFbmM4pqd0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786963996; c=relaxed/simple; bh=5ie2AMA4OlqzsKLIWhQVFxljsBecwzGm3eWQ2SoxBMw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=jgSCto2eKrpm5qNS5Gm9CZJLRdXmT6WgONEMdpuLddSxOT0cu3JUciIwo43vdTZQPtQzJj7qe5aXK6nbKW+M5LAJPQFQ3Z3XmrBZS55S64GloveoCNs94dqOSP96IbTZyBiFheapawWqTO2CskmGs9QdN9jl+FlABUvyFKXRCz8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NIirbdP8; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NIirbdP8" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-49554ebb87dso32241945e9.3 for ; Mon, 17 Aug 2026 03:53:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786963990; x=1787568790; darn=vger.kernel.org; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Njn/5IXjz288EjWMX6pRlyreJSk0SUvuSaQvQyxwDsE=; b=NIirbdP8Pf7nth8sthj/nml01zoXpSTgUyFRVCVArUPHKH7qRM464Bc2tLq5z/vyda LW3LIKMuf/+zlLnB9Cx4XaXZ4Q83HxBFE47HfWoWOcyuYKtgok1pihcIqXgyakUFrq1o U/A5CsnlwnXc5GRI799nTT/0fbwdNDvB9iQ2wEqKAJzfbgqbjixI70VoO+O2T/PagTSu WXoXTLEgPZ4JaMzv0pDtBW+gScKr93bx5gOHGsx/Gtj4jmxg2qR7/0i1tnhjXP0Iziyu DOtW4zc15BNmzm//jYnD3Jp1OHaH/yKh+2o0uhYk3JFpoEpZ5BLmkBB0s4I3mzvYxIDo 9hTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786963990; x=1787568790; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Njn/5IXjz288EjWMX6pRlyreJSk0SUvuSaQvQyxwDsE=; b=PKth8723be4pSFwx4bYartjcKQphLNFJ86iutJRrwQHXXL8Yjur06mJELI4aGpfyn8 oUzs2x3FoyCm/bROeM85HYPyZrrXVfQXl1iSiP8ofOctJdbAhGI08dK1RpmXs5bL26zT +GnqvZOhyOhYebFCtNvp8ZqriOVLoLEgEYpCd/MlGkaFPBN9T5deBGbhngqZcuvi+JOH cfXOS9Lj09mlZ7mnJURUsSbEfN06SCcPpELA/UyhgmbWPg7HvZR6KSwVVLI8/QQTbwU4 rrjQYcw2QZewKUS14RihfsCMKi4EjYzJAxmYNHcTtVQCDzPK3j2YCpfBb0LrRzLJbD4D AlvA== X-Gm-Message-State: AOJu0Yys8n4Z8rfkIWKqKFaX6uswElCvhSMKhBXSvTIP6JxZdXrM/34Z g46qLPDd6CGPgg9V7R5jFzB3np1eO/7LtVTP5D24RP2w9E76cXCO1kwG X-Gm-Gg: AR+sD12Bh3NNyZKo4eaTg6tA2BQWtHuBRTo1JXgXsiSayy46mupEll63yktN9BHOIQ2 MAETEG1SdnkwGNSoI3Uhl+ykkoWNje74C8IyOeIz3VksaES1AAaTZlnoljTNxbSKOpN5ATkRE+N w0mRH47hKsKAxFGqWdQAETr8Qc+VkNNHkWbDtlOqMMUid1mgBf3s7nzJv4XF0gPaf6PbXH8vbbQ ThIts08BkwX/rtCNvGzXPITluACV4zb2AmIH4GO0vQCDVdblS/A0Dhm69jT9Eh7sQuRsV0jmYc+ /vo5ezc7A8d9Qd+Tk7nv2lEULuta+7qXF1iUIwwxJyT/rAU0ozptzveaBOo2X1iaUNMJgah9+qj 9m81JA9DlDqWLgATTvbfLaU/E9Hkmqxpbg7N8sDhx/Zq1r6vChqhnVhcVhuXaaF38C9XP1WG/5u vuLQn1Ry2MtjY57FXPTv7+LtQGd0wkJUt/nwdi5V2kHcRHNpurrsKPOqHnD01pMTSPKfBUKvoVu /JLDGupHrGdf3DOF3RFkA== X-Received: by 2002:a7b:c5ce:0:b0:499:726c:d658 with SMTP id 5b1f17b1804b1-499879bb9e5mr264052275e9.19.1786963989505; Mon, 17 Aug 2026 03:53:09 -0700 (PDT) Received: from Abds-MacBook-Air.local ([141.2.113.154]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49987b1a31esm283048745e9.2.2026.08.17.03.53.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 03:53:08 -0700 (PDT) From: Abd-Alrhman Masalkhi To: Zizhi Wo , song@kernel.org, yukuai@fygo.io, magiclinan@didiglobal.com, xiao@kernel.org, linux-raid@vger.kernel.org Cc: linux-kernel@vger.kernel.org, yangerkun@huawei.com, chengzhihao1@huawei.com, wozizhi@huawei.com Subject: Re: [PATCH V2 2/2] md/raid10: fix missing wakeup in wait_barrier_nolock In-Reply-To: <20260817033340.418119-3-wozizhi@huawei.com> References: <20260817033340.418119-1-wozizhi@huawei.com> <20260817033340.418119-3-wozizhi@huawei.com> Date: Mon, 17 Aug 2026 12:53:03 +0200 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Mon, Aug 17, 2026 at 11:33 +0800, Zizhi Wo wrote: > [BUG] > Recently, our fuzz testing triggered a hungtask issue in RAID10: > > INFO: task md0_raid10:1273 blocked for more than 120 seconds. > Not tainted 7.2.0-rc6+ #94 > "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. > task:md0_raid10 state:D stack:0 pid:1273 tgid:1273 ppid:2 > Call Trace: > > __schedule+0xdf9/0x5c90 > ? _raw_spin_unlock_irqrestore+0xe/0x40 > schedule+0x74/0x1f0 > raid10d.cold+0x7db/0x1992 > md_thread+0x1ce/0x3e0 > kthread+0x327/0x410 > ...... > > [CAUSE] > The root cause of the issue is as follows: > [read process1] [read process2] [raid10d] > raid10_make_request > ... > // nr_pending == 1 > atomic_inc(&conf->nr_pending) > ... > raid10_end_read_request > reschedule_retry > md_wakeup_thread(mddev->thread) > raid10_read_request > regular_request_wait > wait_barrier > wait_barrier_nolock > seq = read_seqbegin(&conf->resync_lock) > // nr_pending == 2 > atomic_inc(&conf->nr_pending) > raid10d > handle_read_error > freeze_array > write_seqlock_irq(&conf->resync_lock) > conf->array_freeze_pending++ > WRITE_ONCE(conf->barrier, conf->barrier + 1) > conf->nr_waiting++ > // nr_pending == 2, nr_queued == 0 > wait_event_barrier_cmd > write_sequnlock_irq(&(conf)->resync_lock) > schedule // hungtask!! > read_seqretry(&conf->resync_lock, seq) > // not wakeup because conf->nr_pending == 1 > atomic_dec_and_test(&conf->nr_pending) > /* Hungtask will also occur here: since the barrier is non-zero, > * this I/O can never complete, so it can't call allow_barrier() > * to wake up the pending freeze_array(). */ > wait_event_barrier(conf, stop_waiting_barrier(conf)) > > wait_barrier_nolock() speculatively increments nr_pending and, on a seqlock > retry, rolls it back with atomic_dec_and_test(). The wake fires only when > nr_pending reaches 0. This causes the freeze_array() in the aforementioned > raid10d flow to never be woken up. > > [FIX] > Referring to allow_barrier(), this issue can be fixed by adding a wake-up > condition for "conf->array_freeze_pending" in wait_barrier_nolock(). > > Fixes: b9b083f9044a ("md/raid10: convert resync_lock to use seqlock") > Signed-off-by: Zizhi Wo > --- > drivers/md/raid10.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c > index dc40110a6736..8dadf13c2b4d 100644 > --- a/drivers/md/raid10.c > +++ b/drivers/md/raid10.c > @@ -994,11 +994,12 @@ static bool wait_barrier_nolock(struct r10conf *conf) > > atomic_inc(&conf->nr_pending); > if (!read_seqretry(&conf->resync_lock, seq)) > return true; > > - if (atomic_dec_and_test(&conf->nr_pending)) > + if (atomic_dec_and_test(&conf->nr_pending) || > + READ_ONCE(conf->array_freeze_pending)) > wake_up_barrier(conf); > > return false; > } > > -- > 2.52.0 > > It looks good to me. Reviewed-by: Abd-Alrhman Masalkhi -- Best Regards, Abd-Alrhman