From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751109AbdARWUO (ORCPT <rfc822;w@1wt.eu>);
        Wed, 18 Jan 2017 17:20:14 -0500
Received: from mail-pg0-f44.google.com ([74.125.83.44]:35581 "EHLO
        mail-pg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750965AbdARWUM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 18 Jan 2017 17:20:12 -0500
From: Kevin Hilman <khilman@baylibre.com>
To: Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>
Cc: linux-amlogic@lists.infradead.org, Mark Rutland <mark.rutland@arm.com>,
        devicetree@vger.kernel.org, Will Deacon <will.deacon@arm.com>,
        linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Carlo Caione <carlo@caione.org>, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro
Organization: BayLibre
References: <20170117030611.23827-1-afaerber@suse.de>
        <20170117030611.23827-2-afaerber@suse.de>
        <63fbfc68-917f-68b2-9e7d-e1834e2841d3@suse.de>
Date: Wed, 18 Jan 2017 14:18:39 -0800
In-Reply-To: <63fbfc68-917f-68b2-9e7d-e1834e2841d3@suse.de> ("Andreas
        =?utf-8?Q?F=C3=A4rber=22's?= message of "Tue, 17 Jan 2017 04:35:10 +0100")
Message-ID: <m27f5sypts.fsf@baylibre.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (darwin)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v0IMKl1d020382

Andreas Färber <afaerber@suse.de> writes:

> Am 17.01.2017 um 04:06 schrieb Andreas Färber:
>> +	leds {
>> +		compatible = "gpio-leds";
>> +
>> +		blue {
>> +			label = "rbox-pro:blue:on";
>> +			gpios = <&gpio_ao GPIOAO_9 GPIO_ACTIVE_HIGH>;
>> +			default-state = "on";
>> +		};
>> +
>> +		red {
>> +			label = "rbox-pro:red:standby";
>> +			gpios = <&gpio GPIODV_28 GPIO_ACTIVE_HIGH>;
>> +			default-state = "off";
>> +			retain-state-suspended;
>> +			panic-indicator;
>> +		};
>> +	};
>
> The original property names for these two were led and red. If anyone
> has better label names than the above, please speak up. Ditto for
> vega-s95. On the odroidc2 it's called alive but uses heartbeat there.
>
> The vendor device tree had a third "mcu" GPIO in the sysled node,
> GPIOAO_6, which leads to immediate power-off. I tried using
> "gpio-poweroff" to configure this pin, but that driver fails to
> initialize because some pm callback is already registered - I assume
> from psci, which apparently succeeds to power-off the system, too. For
> comparison, the S905 based Vega S95 Telos has no such mcu property. Any
> thoughts?
>
> Also, any ideas how best to switch from blue to red for suspend? Add
> pinctrl properties above? systemd service doing echo from userspace? I
> assume in Android the Amlogic sysled driver handles all that logic -
> didn't find any suspend equivalent to gpio-poweroff.

in leds-gpio, when retain-state-suspended is not set, the LED is
automatically set to value 0.  I wonder if leds-gpio should grow support
to make the suspend value configurable?  Or a property like
"toggle-state-suspended" ?

Kevin