Re: [PATCH 2/2] md: add a control device for array management

[Abd-Alrhman Masalkhi <abd.masalkhi@gmail.com>]

Hi Greg,

Thank you for your review.

On Tue, Sep 29, 2026 at 06:49 +0200, Greg KH wrote:
> On Mon, Sep 28, 2026 at 08:12:24PM +0000, Abd-Alrhman Masalkhi wrote:
>> Add a misc character device, /dev/md-control, with a fixed minor
>> MD_CTRL_MINOR. The control device is not tied to any md device, each
>> request specifies the array in the payload, either by name, by UUID or
>> by device number, without the need to open the md block device.
>
> Why is this a fixed number and not a dynamic one?  There should not eve
> be a need for fixed numbers anymore.
>
>> --- /dev/null
>> +++ b/drivers/md/md-ctl.c
>> @@ -0,0 +1,597 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +
>
> No copyright information?
>
I will add it in v2.

>> diff --git a/include/linux/miscdevice.h b/include/linux/miscdevice.h
>> index fa9000f68523..0bf2870dc191 100644
>> --- a/include/linux/miscdevice.h
>> +++ b/include/linux/miscdevice.h
>> @@ -71,6 +71,7 @@
>>  #define VHOST_VSOCK_MINOR	241
>>  #define EISA_EEPROM_MINOR	241
>>  #define RFKILL_MINOR		242
>> +#define MD_CTRL_MINOR		243
>
> No, please use a dynamic number instead.
>
I will use dynamic number in v2.

> thanks,
>
> greg k-h

-- 
Best Regards,
Abd-Alrhman