mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Ben Dooks <ben-linux@fluff.org>,
	kernel-janitors@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/mmc/host/sdhci-s3c.c: use devm_ functions
Date: Thu, 08 Mar 2012 23:27:41 -0500	[thread overview]
Message-ID: <m2k42uqtz6.fsf@bob.laptop.org> (raw)
In-Reply-To: <1329596019-19822-1-git-send-email-Julia.Lawall@lip6.fr> (Julia Lawall's message of "Sat, 18 Feb 2012 21:13:39 +0100")

Hi Julia,

On Sat, Feb 18 2012, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> The various devm_ functions allocate memory that is released when a driver
> detaches.  This patch uses these functions for data that is allocated in
> the probe function of a platform device and is only freed in the remove
> function.
>
> By using devm_ioremap, it also removes a potential memory leak, because
> there was no call to iounmap in the probe function.
>
> The call to platform_get_resource was moved just to make it closer to the
> place where its result it used.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Thanks very much, pushed to mmc-next for 3.4.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

      reply	other threads:[~2012-03-09  4:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-18 20:13 Julia Lawall
2012-03-09  4:27 ` Chris Ball [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2k42uqtz6.fsf@bob.laptop.org \
    --to=cjb@laptop.org \
    --cc=Julia.Lawall@lip6.fr \
    --cc=ben-linux@fluff.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®