From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755300Ab1G0Vrh (ORCPT ); Wed, 27 Jul 2011 17:47:37 -0400 Received: from void.printf.net ([89.145.121.20]:57988 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753952Ab1G0Vrd (ORCPT ); Wed, 27 Jul 2011 17:47:33 -0400 From: Chris Ball To: "Rafael J. Wysocki" Cc: Linus Torvalds , LKML , linux-sh@vger.kernel.org, "Greg Kroah-Hartman" , linux-usb@vger.kernel.org, linux-mmc@vger.kernel.org Subject: Re: [PATCH 1/2] MMC / TMIO: Fix build issue related to struct scatterlist References: <201107262049.15333.rjw@sisk.pl> <201107262050.23379.rjw@sisk.pl> Date: Wed, 27 Jul 2011 17:47:01 -0400 In-Reply-To: <201107262050.23379.rjw@sisk.pl> (Rafael J. Wysocki's message of "Tue, 26 Jul 2011 20:50:23 +0200") Message-ID: User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rafael, On Tue, Jul 26 2011, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Fix build issue caused by undefined struct scatterlist in > drivers/mmc/host/tmio_mmc.c. > > Signed-off-by: Rafael J. Wysocki > --- > drivers/mmc/host/tmio_mmc.h | 1 + > drivers/usb/renesas_usbhs/fifo.c | 1 + > 2 files changed, 2 insertions(+) > > Index: linux-2.6/drivers/mmc/host/tmio_mmc.h > =================================================================== > --- linux-2.6.orig/drivers/mmc/host/tmio_mmc.h > +++ linux-2.6/drivers/mmc/host/tmio_mmc.h > @@ -21,6 +21,7 @@ > #include > #include > #include > +#include > > /* Definitions for values the CTRL_SDIO_STATUS register can take. */ > #define TMIO_SDIO_STAT_IOIRQ 0x0001 I'm not able to reproduce the build failure here. drivers/mmc/host/tmio_mmc.c already performs "#include " itself (and always has done), so I'm confused about why this is necessary. Do you have a copy of your build log with the error? Thanks, - Chris. -- Chris Ball One Laptop Per Child