From: Andi Kleen <andi@firstfloor.org>
To: Ivo Sieben <meltedpianoman@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
<linux-serial@vger.kernel.org>, Alan Cox <alan@linux.intel.com>,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [REPOST] RFC: sched: Prevent wakeup to enter critical section needlessly
Date: Tue, 09 Oct 2012 06:37:27 -0700 [thread overview]
Message-ID: <m2r4p7u5pk.fsf@firstfloor.org> (raw)
In-Reply-To: <1349782235-8896-1-git-send-email-meltedpianoman@gmail.com> (Ivo Sieben's message of "Tue, 9 Oct 2012 13:30:35 +0200")
Ivo Sieben <meltedpianoman@gmail.com> writes:
> Check the waitqueue task list to be non empty before entering the critical
> section. This prevents locking the spin lock needlessly in case the queue
> was empty, and therefor also prevent scheduling overhead on a PREEMPT_RT
> system.
>
> Signed-off-by: Ivo Sieben <meltedpianoman@gmail.com>
> ---
>
> REPOST:
> Request for comments:
> - Does this make any sense?
Looks good to me. Avoiding any spinlock is good. I don't even think you
need "careful", if you miss an update it was just as it happened a
little later.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2012-10-09 13:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 13:06 [PATCH] " Ivo Sieben
2012-10-09 11:30 ` [REPOST] " Ivo Sieben
2012-10-09 13:37 ` Andi Kleen [this message]
2012-10-09 14:15 ` Peter Zijlstra
2012-10-09 15:17 ` Oleg Nesterov
2012-10-10 14:02 ` Andi Kleen
2012-10-18 8:30 ` [PATCH-v2] " Ivo Sieben
2012-10-25 10:12 ` [REPOST-v2] " Ivo Sieben
2012-11-19 7:30 ` Ivo Sieben
2012-11-19 10:20 ` Preeti U Murthy
2012-11-19 15:10 ` Oleg Nesterov
2012-11-19 15:34 ` Ivo Sieben
2012-11-19 15:49 ` Oleg Nesterov
2012-11-21 13:03 ` Ivo Sieben
2012-11-21 13:47 ` Alan Cox
2012-11-21 13:58 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2r4p7u5pk.fsf@firstfloor.org \
--to=andi@firstfloor.org \
--cc=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=meltedpianoman@gmail.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome