From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753552AbcHPNMw (ORCPT ); Tue, 16 Aug 2016 09:12:52 -0400 Received: from mail-io0-f171.google.com ([209.85.223.171]:35935 "EHLO mail-io0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753453AbcHPNMs (ORCPT ); Tue, 16 Aug 2016 09:12:48 -0400 From: Kevin Hilman To: Daniel Wagner Cc: Wolfram Sang , Kamal Dasu , Tim Kryger , Ray Jui , Daniel Wagner , linux-kernel@vger.kernel.org, Beniamino Galvani , bcm-kernel-feedback-list@broadcom.com, linux-i2c@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v0 4/4] i2c: meson: Use complete() instead of complete_all() Organization: BayLibre References: <1470225791-16613-1-git-send-email-wagi@monom.org> <1470225791-16613-5-git-send-email-wagi@monom.org> Date: Tue, 16 Aug 2016 08:12:45 -0500 In-Reply-To: <1470225791-16613-5-git-send-email-wagi@monom.org> (Daniel Wagner's message of "Wed, 3 Aug 2016 14:03:11 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (darwin) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Daniel Wagner writes: > From: Daniel Wagner > > There is only one waiter for the completion, therefore there > is no need to use complete_all(). Let's make that clear by > using complete() instead of complete_all(). > > The usage pattern of the completion is: > > meson_i2c_xfer_msg() > reinit_completion() > ... > /* Start the transfer */ > ... > wait_for_completion_timeout() > > Signed-off-by: Daniel Wagner Acked-by: Kevin Hilman