From: Christian Krause <Christian.Krause@informatik.tu-chemnitz.de>
To: Greg KH <greg@kroah.com>
Cc: Chris Wright <chrisw@osdl.org>,
kernel-stuff@comcast.net, stable@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [stable] Re: [PATCH] Re: bug in handling of highspeed usb HID devices
Date: Fri, 14 Oct 2005 19:46:02 +0200 [thread overview]
Message-ID: <m37jcg3sbp.fsf@gondor.middle-earth.priv> (raw)
In-Reply-To: <20051014171326.GA16496@kroah.com> (Greg KH's message of "Fri, 14 Oct 2005 10:13:26 -0700")
On Fri, 14 Oct 2005 10:13:26 -0700, Greg KH wrote:
> On Thu, Oct 13, 2005 at 02:25:18PM -0700, Chris Wright wrote:
>> * kernel-stuff@comcast.net (kernel-stuff@comcast.net) wrote:
>> > This seems to be -stable material since it's a clear cut bug with bad
>> > consequences.
>> >
>> > Chris Wright - is the below patch acceptable for -stable?
> Also, I don't think this should go into -stable, as there are no
> high-speed HID devices available right now, so it really isn't affecting
> anyone :)
No, that's no correct. There are such devices:
Newer KVM-over-IP appliances, like the Avocent's DSR2030 emulates
keyboard, mouse and a mass storage device over USB. I've tested this
specific device with linux and the USB transfers are Highspeed and the
USB device has one interface which is HID. So there are Highspeed USB
devices out there.
With all respect, but I don't really understand why this is important.
The linux kernel clearly violates the USB specification. The calculation of
the real polling interval for interrupt endpoints is
i = 2^(bInterval-1) (according to USB 2.0 spec, chapter 9.6.6) and _not_
i = 2^((2^(bInterval-1))-1) as it is calculated in linux.
This is clearly a bug in linux and should be fixed.
Changing this has _no_ impact on other devices than Highspeed HID devices
and only this patch allows them to work. And there are such devices. At
least Avocent's DSR2030.
Best regards,
Christian
next prev parent reply other threads:[~2005-10-14 17:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-13 19:53 kernel-stuff
2005-10-13 21:25 ` Chris Wright
2005-10-13 22:46 ` [stable] " Greg KH
2005-10-14 17:13 ` Greg KH
2005-10-14 17:46 ` Christian Krause [this message]
2005-10-14 18:10 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37jcg3sbp.fsf@gondor.middle-earth.priv \
--to=christian.krause@informatik.tu-chemnitz.de \
--cc=chrisw@osdl.org \
--cc=greg@kroah.com \
--cc=kernel-stuff@comcast.net \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®