mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Halasa <khc@pm.waw.pl>
To: Tim Cambrant <tim@cambrant.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [Newbie-warning] MOD_INC_USE_COUNT usage
Date: Wed, 14 Jan 2004 19:25:04 +0100	[thread overview]
Message-ID: <m37jzuv14v.fsf@defiant.pm.waw.pl> (raw)
In-Reply-To: <20040114172022.GA2112@cambrant.com> (Tim Cambrant's message of "Wed, 14 Jan 2004 18:20:22 +0100")

Tim Cambrant <tim@cambrant.com> writes:

> So, why shouldn't this patch be applied?:
>
> --- drivers/ide/pci/generic.c.orig      2004-01-14 17:52:35.000000000 +0100
> +++ drivers/ide/pci/generic.c   2003-11-24 13:54:01.000000000 +0100
> @@ -121,6 +121,7 @@ static int __devinit generic_init_one(st
> 		return 1;
> 	}
> 	ide_setup_pci_device(dev, d);
> +	MOD_INC_USE_COUNT;
> 	return 0;
>  }

It isn't that easy - the module must be marked as being in use this
way or (preferably) another.
-- 
Krzysztof Halasa, B*FH

  reply	other threads:[~2004-01-14 18:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-14 17:20 Tim Cambrant
2004-01-14 18:25 ` Krzysztof Halasa [this message]
2004-01-15 13:53   ` Yury V. Umanets

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m37jzuv14v.fsf@defiant.pm.waw.pl \
    --to=khc@pm.waw.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tim@cambrant.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®