From: khalasa@piap.pl (Krzysztof Hałasa)
To: lkml <linux-kernel@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>,
Russell King <rmk+kernel@arm.linux.org.uk>
Subject: Regression (ARM) arch/arm/mm/init.c doesn't build without CONFIG_ARM_PATCH_PHYS_VIRT.
Date: Tue, 31 Dec 2013 12:20:56 +0100 [thread overview]
Message-ID: <m38uv1uuzr.fsf@t19.piap.pl> (raw)
arch/arm/mm/init.c: In function 'setup_dma_zone':
arch/arm/mm/init.c:232:19: error: '__pv_phys_offset' undeclared (first use in this function)
Reverting the following commit fixes it:
commit 787b0d5c1ca7ff24feb6f92e4c7f4410ee7d81a8
Author: Santosh Shilimkar <santosh.shilimkar@ti.com>
Date: Mon Dec 2 20:29:12 2013 +0100
ARM: 7908/1: mm: Fix the arm_dma_limit calculation
Current code is using PHYS_OFFSET to calculate the arm_dma_limit which
will lead to wrong calculations in cases where PHYS_OFFSET is updated
runtime.
So fix the code by using __pv_phys_offset instead of PHYS_OFFSET.
It seems PHYS_OFFSET is equal to __pv_phys_offset if the latter is
available:
arch/arm/include/asm/memory.h:#define PHYS_OFFSET __pv_phys_offset
Otherwise (without CONFIG_ARM_PATCH_PHYS_VIRT) PHYS_OFFSET is a
hard-coded CONFIG value, or whatever the platform/CPU code needs:
arch/arm/include/asm/memory.h:#define PHYS_OFFSET PLAT_PHYS_OFFSET
Perhaps the patch in question was needed at some point but I think the
situation had changed before it was commited.
--
Krzysztof Halasa
Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
next reply other threads:[~2013-12-31 11:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-31 11:20 Krzysztof Hałasa [this message]
2013-12-31 11:23 ` Russell King - ARM Linux
2014-01-01 14:40 ` Krzysztof Hałasa
2014-01-06 19:28 ` Krzysztof Hałasa
2014-01-06 19:33 ` Santosh Shilimkar
2014-01-06 22:08 ` Krzysztof Hałasa
2014-01-06 22:27 ` Santosh Shilimkar
2014-01-06 22:39 ` Russell King - ARM Linux
2014-01-06 23:42 ` Santosh Shilimkar
2014-01-07 1:11 ` Russell King - ARM Linux
2014-01-07 17:45 ` Santosh Shilimkar
2014-01-07 17:55 ` Russell King - ARM Linux
2014-01-08 6:40 ` Krzysztof Hałasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m38uv1uuzr.fsf@t19.piap.pl \
--to=khalasa@piap.pl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome