From: Alex Tomas <alex@clusterfs.com>
To: "Stephen C. Tweedie" <sct@redhat.com>
Cc: Alex Tomas <alex@clusterfs.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
<ext2-devel@lists.sourceforge.net>, Andrew Morton <akpm@osdl.org>
Subject: Re: [Ext2-devel] [PATCH] JBD: fix against journal overflow
Date: Mon, 24 Jan 2005 22:27:06 +0300 [thread overview]
Message-ID: <m38y6ieigl.fsf@bzzz.home.net> (raw)
In-Reply-To: <1106590709.2103.132.camel@sisko.sctweedie.blueyonder.co.uk> (Stephen C. Tweedie's message of "Mon, 24 Jan 2005 18:18:29 +0000")
>>>>> Stephen C Tweedie (SCT) writes:
SCT> /*
SCT> * Be pessimistic here about the number of those free blocks which
SCT> * might be required for log descriptor control blocks.
SCT> */
SCT> ...
SCT> left -= (left >> 3);
oops. i overlooked this line. so, the fix becomes minor improvement patch ;)
thanks!
do you think the following can be improved?
/*
* @@@ AKPM: This seems rather over-defensive. We're giving commit
* a _lot_ of headroom: 1/4 of the journal plus the size of
* the committing transaction. Really, we only need to give it
* committing_transaction->t_outstanding_credits plus "enough" for
* the log control blocks.
* Also, this test is inconsitent with the matching one in
* journal_extend().
*/
if (__log_space_left(journal) < jbd_space_needed(journal)) {
next prev parent reply other threads:[~2005-01-24 19:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-19 15:32 Alex Tomas
2005-01-24 17:43 ` [Ext2-devel] " Stephen C. Tweedie
2005-01-24 17:47 ` Alex Tomas
2005-01-24 18:18 ` Stephen C. Tweedie
2005-01-24 19:27 ` Alex Tomas [this message]
2005-01-24 20:42 ` Stephen C. Tweedie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m38y6ieigl.fsf@bzzz.home.net \
--to=alex@clusterfs.com \
--cc=akpm@osdl.org \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sct@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®