From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753394AbYIDXI6 (ORCPT ); Thu, 4 Sep 2008 19:08:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754432AbYIDXIg (ORCPT ); Thu, 4 Sep 2008 19:08:36 -0400 Received: from khc.piap.pl ([195.187.100.11]:57212 "EHLO khc.piap.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753962AbYIDXIf (ORCPT ); Thu, 4 Sep 2008 19:08:35 -0400 To: "Frans Meulenbroeks" Cc: "Nye Liu" , "Andrew Morton" , "Nye Liu" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] INITRAMFS: Add option to preserve mtime from INITRAMFS cpio images References: <20080805195232.GA5183@curtisfong.org> <20080903202938.GA9065@curtisfong.org> <20080903152231.6b82d9bf.akpm@linux-foundation.org> <20080903223114.GA9456@mrv.com> From: Krzysztof Halasa Date: Fri, 05 Sep 2008 01:08:32 +0200 In-Reply-To: (Frans Meulenbroeks's message of "Thu\, 4 Sep 2008 09\:11\:42 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Frans Meulenbroeks" writes: > "Invaluable" != "nice to know". Well, I guess it's as "invaluable" for embedded systems running on initramfs as mtime on regular filesystems in case of normal systems. Is mtime on ext3 "invaluable" or just "nice to know"? > I admit that the net effect of this on boot time is marginal (but some > might consider having mtime a marginal benefit), and 100 cents also > make a dollar, so my suggestion would be to either reject this patch > or make it optional (e.g. depending on some debug config flag). It depends on how marginal is it. If it makes unpacking 1% slower I can see no need for being optional. 10% - maybe it should? -- Krzysztof Halasa