From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753384AbbKYMbT (ORCPT ); Wed, 25 Nov 2015 07:31:19 -0500 Received: from ni.piap.pl ([195.187.100.4]:44516 "EHLO ni.piap.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753098AbbKYMbS (ORCPT ); Wed, 25 Nov 2015 07:31:18 -0500 From: khalasa@piap.pl (Krzysztof =?utf-8?Q?Ha=C5=82asa?=) To: Arnd Bergmann Cc: Imre Kaloz , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: ixp4xx: fix read{b,w,l} return types References: <4577677.sEiIMqkHSM@wuerfel> Date: Wed, 25 Nov 2015 13:31:16 +0100 In-Reply-To: <4577677.sEiIMqkHSM@wuerfel> (Arnd Bergmann's message of "Fri, 20 Nov 2015 23:20:28 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-KLMS-Rule-ID: 1 X-KLMS-Message-Action: clean X-KLMS-AntiSpam-Lua-Profiles: 87289 [Nov 25 2015] X-KLMS-AntiSpam-Version: 5.5.6 X-KLMS-AntiSpam-Envelope-From: khalasa@piap.pl X-KLMS-AntiSpam-Rate: 0 X-KLMS-AntiSpam-Status: not_detected X-KLMS-AntiSpam-Method: none X-KLMS-AntiSpam-Moebius-Timestamps: 3837939, 3837997, 3836528 X-KLMS-AntiSpam-Info: LuaCore: 332 332 32935ab67f142fee7066f843e4c522947659d7e3, Auth:dkim=none X-KLMS-AntiSpam-Interceptor-Info: scan successful X-KLMS-AntiPhishing: Clean, 2015/11/24 11:13:06 X-KLMS-AntiVirus: Kaspersky Security 8.0 for Linux Mail Server, version 8.0.1.721, bases: 2015/11/25 06:17:00 #6777909 X-KLMS-AntiVirus-Status: Clean, skipped Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann writes: > On ixp4xx, the readl() function returns an 'unsigned long' output > when indirect I/O is used. This is unlike any other platform, and > it causes lots of harmless compiler warnings, such as: > > drivers/ata/libahci.c: In function 'ahci_show_host_version': > drivers/ata/libahci.c:254:22: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long unsigned int' [-Wformat=] > drivers/block/mtip32xx/mtip32xx.c: In function 'mtip_hw_read_registers': > drivers/block/mtip32xx/mtip32xx.c:2602:31: warning: format '%X' expects argument of type 'unsigned int', but argument 3 has type 'long unsigned int' [-Wformat=] > drivers/block/cciss.c: In function 'print_cfg_table': > drivers/block/cciss.c:3845:25: warning: format '%d' expects argument of type 'int', but argument 4 has type 'long unsigned int' [-Wformat=] > > This changes all six of the ixp4xx specific I/O read functions > to return the same types that we have in the normal asm/io.h, > to avoid the warnings. Thanks for fixing this. Acked-by: Krzysztof Halasa -- Krzysztof Halasa Industrial Research Institute for Automation and Measurements PIAP Al. Jerozolimskie 202, 02-486 Warsaw, Poland