From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751965AbaLESBP (ORCPT ); Fri, 5 Dec 2014 13:01:15 -0500 Received: from mga03.intel.com ([134.134.136.65]:8691 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751594AbaLESBO (ORCPT ); Fri, 5 Dec 2014 13:01:14 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,523,1413270000"; d="scan'208";a="649054920" From: Ashutosh Dixit To: Dan Streetman Cc: Jonathan Corbet , Jiri Kosina , Peter Foley , Randy Dunlap , Greg Kroah-Hartman , Jennings , "Yokoyama\, Caz" , "Dutt\, Sudeep" , "Chandramouli\, Dasaratharaman" , linux-kernel , "linux-doc\@vger.kernel.org" , "Rao\, Nikhil" , Daniel Borkmann , "linuxppc-dev\@lists.ozlabs.org" , Siva Yerramreddy Subject: Re: [PATCH linux-next] Documentation: Build mic/mpssd only for x86_64 References: <25c04eb72c621fc9bdf0aae25782ff5bad5a4b97.1417728278.git.ashutosh.dixit@intel.com> Date: Fri, 05 Dec 2014 10:18:57 -0800 In-Reply-To: (Dan Streetman's message of "Thu, 4 Dec 2014 20:27:06 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 04 2014 at 07:27:06 PM, Dan Streetman wrote: > On Thu, Dec 4, 2014 at 4:27 PM, Ashutosh Dixit wrote: >> mic/mpssd along with MIC drivers are currently only usable on >> x86_64. So build mic/mpssd only for x86_64 to avoid build breaks on >> big-endian systems. > > Only building for x86_64 is fine, but in that case what's the point of > leaving the htole16() et. al. functions in mpssd.c? Shouldn't they be > removed? I am hoping that once glibc is fixed we can remove this limitation on building only for x86_64, so I'd rather htole16() et. al. stayed. As I said earlier, I'm fine with your patch too, but restricting the build for x86_64 seems to be the smallest patch which provides an acceptable solution.