Re: [PATCH] WAN/pc300: handle, propagate minor errors

[Krzysztof Halasa <khc@pm.waw.pl>]

Hi,

Jeff Garzik <jeff@garzik.org> writes:

> - move definition of 'tmc' and 'br' locals closer to usage
>
> - handle clock_rate_calc() error
>
> - propagate errors back to upper level open routine

>  drivers/net/wan/pc300_drv.c |   24 +++++++++++++++++++-----

Looks good (not sure if my ACK counts, I'm not the maintainer).


FYI: I think the pc300 driver would benefit from, I'd say, a bit
of maintenance. Cyclades don't sell PC300 anymore (at least their
WWW doesn't list them) and I don't know if they're going to touch
the driver.

I have a much simpler driver for PC300 X.21 and V.24/V.35 models
(could be included in the official kernel), but it lacks support
for T1/E1 cards.

I could look at their driver and try to incorporate T1/E1 support
into my driver, but without access to the hardware it would be
tricky at best.

Not sure what should we do. Perhaps waiting for Cyclades is the
only option.

PC300 are nice cards, it would be sad if the driver support
deteriorated.
-- 
Krzysztof Halasa