From: Krzysztof Halasa <khc@pm.waw.pl>
To: Roel Kluin <12o3l@tiscali.nl>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/net/wan/wanxl.c: time_before(timeout, jiffies) -> jiffies, timeout
Date: Mon, 24 Mar 2008 15:42:38 +0100 [thread overview]
Message-ID: <m3k5js2nfl.fsf@maximus.localdomain> (raw)
In-Reply-To: <47E28637.4010700@tiscali.nl> (Roel Kluin's message of "Thu\, 20 Mar 2008 16\:43\:51 +0100")
Hi,
Roel Kluin <12o3l@tiscali.nl> writes:
> --- a/drivers/net/wan/wanxl.c
> +++ b/drivers/net/wan/wanxl.c
> @@ -650,7 +650,7 @@ static int __devinit wanxl_pci_init_one(struct pci_dev *pdev,
>
> timeout = jiffies + 20 * HZ;
> while ((stat = readl(card->plx + PLX_MAILBOX_0)) != 0) {
> - if (time_before(timeout, jiffies)) {
> + if (time_before(jiffies, timeout)) {
> printk(KERN_WARNING "wanXL %s: timeout waiting for"
> " PUTS to complete\n", pci_name(pdev));
> wanxl_pci_remove_one(pdev);
>
I can't see a bug here - time_before(timeout, jiffies) means "if
timeout is before jiffies", IOW if jiffies passed the timeout.
Perhaps time_after(jiffies, timeout) is a bit better equivalent, I
will use that.
--
Krzysztof Halasa
prev parent reply other threads:[~2008-03-24 14:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-20 15:43 Roel Kluin
2008-03-20 16:46 ` Joe Perches
2008-03-20 20:23 ` Roel Kluin
2008-03-20 21:06 ` Joe Perches
2008-03-24 15:01 ` Krzysztof Halasa
2008-03-24 15:52 ` Joe Perches
2008-03-24 20:22 ` Krzysztof Halasa
2008-03-24 14:42 ` Krzysztof Halasa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3k5js2nfl.fsf@maximus.localdomain \
--to=khc@pm.waw.pl \
--cc=12o3l@tiscali.nl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®