From: Dmitri Monakhov <dmonakhov@openvz.org>
To: linux-kernel@vger.kernel.org
Cc: Jens Axboe <jens.axboe@oracle.com>, Alasdair G Kergon <agk@redhat.com>
Subject: [PATCH] block: fix bio_add_page for non trivial merge_bvec_fn case(v2)
Date: Sat, 05 Jul 2008 18:16:04 +0400 [thread overview]
Message-ID: <m3lk0gh0wr.fsf@dmon-lap.sw.ru> (raw)
We have to properly decrease bi_size in order to merge_bvec_fn return
right result. Otherwise this result in false merge rejects for two
absolutely valid bio_vecs. This may cause significant performance penalty
for example Itanium: page_size ==16k, fs_block_size == 1k and block device
is raid with small chunk_size.
Changes against v1:
According to axboe@ and agk@ we don't have to decrease bi_vcnt and segments
counters, so patch now looks like one line fix.
Signed-off-by: Dmitri Monakhov <dmonakhov@openvz.org>
---
fs/bio.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/fs/bio.c b/fs/bio.c
index 25f1af0..0e6ed2a 100644
--- a/fs/bio.c
+++ b/fs/bio.c
@@ -330,7 +330,8 @@ static int __bio_add_page(struct request_queue *q, struct bio *bio, struct page
struct bvec_merge_data bvm = {
.bi_bdev = bio->bi_bdev,
.bi_sector = bio->bi_sector,
- .bi_size = bio->bi_size,
+ .bi_size = bio->bi_size -
+ (prev->bv_len - len),
.bi_rw = bio->bi_rw,
};
--
1.5.4.rc4
reply other threads:[~2008-07-05 14:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3lk0gh0wr.fsf@dmon-lap.sw.ru \
--to=dmonakhov@openvz.org \
--cc=agk@redhat.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®