Re: pktcdvd stack usage regression

[Peter Osterlund <petero2@telia.com>]

Adrian Bunk <bunk@stusta.de> writes:

> Hi Phillip,
> 
> your recent patch "pktcdvd: Allow larger packets" changed 
> PACKET_MAX_SIZE in the pktcdvd driver from 32 to 128.
> 
> Unfortunately, drivers/block/pktcdvd.c contains the following:
> 
> <--  snip  -->
> 
> ...
> static void pkt_start_write(struct pktcdvd_device *pd, struct 
> packet_data *pkt)
> {
>         struct bio *bio;
>         struct page *pages[PACKET_MAX_SIZE];
>         int offsets[PACKET_MAX_SIZE];
> ...
> 
> <--  snip  -->
> 
> With PACKET_MAX_SIZE=128, this allocates more than 1 kB on the stack 

Yes, I know.

> which is not acceptable considering that we might have only 4 kB stack 
> altogether.

Why is it not acceptable? The pkt_start_write() function is only
called from the kcdrwd() kernel thread and the pkt_start_write()
function doesn't call anything else in the kernel that could require
lots of stack space.

The actual I/O is started from pkt_iosched_process_queue(), which
calls generic_make_request(). However pkt_iosched_process_queue() is
on a different call chain than pkt_start_write(), so I don't see how
this could be a problem.

-- 
Peter Osterlund - petero2@telia.com
http://web.telia.com/~u89404340