From: Ulrich Drepper <drepper@redhat.com>
To: Russell Coker <russell@coker.com.au>
Cc: linux-kernel@vger.kernel.org, herbert@gondor.apana.org.au
Subject: Re: struct stat{st_blksize} for /dev entries in 2.4.3
Date: 08 Apr 2001 11:46:25 -0700 [thread overview]
Message-ID: <m3snjjnsam.fsf@otr.mynet.cygnus.com> (raw)
In-Reply-To: <01040823491919.25703@lyta>
In-Reply-To: Russell Coker's message of "Sun, 8 Apr 2001 23:49:19 +1000"
Russell Coker <russell@coker.com.au> writes:
> diff -ru textutils-2.0/src/cat.c textutils-new/src/cat.c
> --- textutils-2.0/src/cat.c Sun Apr 8 22:55:10 2001
> +++ textutils-new/src/cat.c Sun Apr 8 23:23:54 2001
> @@ -790,6 +790,9 @@
> if (options == 0)
> {
> insize = max (insize, outsize);
> +#ifdef _SC_PHYS_PAGES
> + insize = max (insize, sysconf(_SC_PAGESIZE));
> +#endif
> inbuf = (unsigned char *) xmalloc (insize);
>
> simple_cat (inbuf, insize);
The #ifdef is certainly wrong. And there is no guarantee that any of
the _SC_* constants are defined as macros. You'll have to add a
configure test.
--
---------------. ,-. 1325 Chesapeake Terrace
Ulrich Drepper \ ,-------------------' \ Sunnyvale, CA 94089 USA
Red Hat `--' drepper at redhat.com `------------------------
next prev parent reply other threads:[~2001-04-08 18:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-08 13:49 Russell Coker
2001-04-08 18:46 ` Ulrich Drepper [this message]
2001-04-09 7:32 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3snjjnsam.fsf@otr.mynet.cygnus.com \
--to=drepper@redhat.com \
--cc=drepper@cygnus.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=russell@coker.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®