From: Krzysztof Halasa <khc@pm.waw.pl>
To: Dmitri Monakhov <dmonakhov@openvz.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] kill suid bit only for regular files
Date: Mon, 27 Oct 2008 16:19:26 +0100 [thread overview]
Message-ID: <m3y70a3w1t.fsf@maximus.localdomain> (raw)
In-Reply-To: <m363nebi2n.fsf@dmon-lap.sw.ru> (Dmitri Monakhov's message of "Mon\, 27 Oct 2008 10\:41\:52 +0300")
Dmitri Monakhov <dmonakhov@openvz.org> writes:
>> Are we sure that should_remove_suid() is not and never will used for
>> directories?
> This bits are meaningless for directory. Posix is quiet about this case.
> Ok. Will do. My point is: it is improbable what some body(except me :) )
> want to set S_ISUID/S_ISGID bit for non regular files. But it is
> technically possible and result in unexpected consequence.
I don't know about the context, but SGID bits for directories are not
magic, they mean the newly created files will inherit GID from the
parent directory, and if the file is actually a subdirectory, it will
also have SGID set. The same was also true WRT SUID bits on some
systems.
--
Krzysztof Halasa
prev parent reply other threads:[~2008-10-27 15:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-19 14:00 Dmitri Monakhov
2008-10-27 4:47 ` Andrew Morton
2008-10-27 7:41 ` Dmitri Monakhov
2008-10-27 15:19 ` Krzysztof Halasa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3y70a3w1t.fsf@maximus.localdomain \
--to=khc@pm.waw.pl \
--cc=akpm@linux-foundation.org \
--cc=dmonakhov@openvz.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®