From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161127AbWGJNJh (ORCPT ); Mon, 10 Jul 2006 09:09:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161134AbWGJNJh (ORCPT ); Mon, 10 Jul 2006 09:09:37 -0400 Received: from khc.piap.pl ([195.187.100.11]:21437 "EHLO khc.piap.pl") by vger.kernel.org with ESMTP id S1161115AbWGJNJg (ORCPT ); Mon, 10 Jul 2006 09:09:36 -0400 To: "Antonino A. Daplas" Cc: Jean Delvare , Andrew Morton , lkml Subject: Re: [PATCH v2] cirrus-logic-framebuffer-i2c-support.patch References: <200607050147.k651kxmT023763@shell0.pdx.osdl.net> <20060705165255.ab7f1b83.khali@linux-fr.org> <44B196ED.1070804@pol.net> <44B226E8.40104@pol.net> <44B2398B.7040300@pol.net> <44B248E4.2020506@pol.net> From: Krzysztof Halasa Date: Mon, 10 Jul 2006 15:09:32 +0200 In-Reply-To: <44B248E4.2020506@pol.net> (Antonino A. Daplas's message of "Mon, 10 Jul 2006 20:32:36 +0800") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org "Antonino A. Daplas" writes: >> You're right here, I don't know why I assumed DEPENDS does it >> automatically. > > Use select. It has a known problem - if the "selected" thing changes (requires another option etc) things are screwed. With "depends on", you don't have to track such changes. While near selects (in the same build directory) are IMHO ok, far ones are not. I think it would be different if trying to select something which can't be selected automatically resulted in a warning. I think I have to look at it then, but for now I'll use something like "depends on (FB_CIRRUS=m && I2C && I2C_ALGOBIT) || (FB_CIRRUS=y && I2C=y && I2C_ALGOBIT=y)". -- Krzysztof Halasa