From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761197Ab3BJUg6 (ORCPT ); Sun, 10 Feb 2013 15:36:58 -0500 Received: from inx.pm.waw.pl ([195.116.170.130]:36372 "EHLO inx.pm.waw.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756689Ab3BJUg5 (ORCPT ); Sun, 10 Feb 2013 15:36:57 -0500 X-Greylist: delayed 388 seconds by postgrey-1.27 at vger.kernel.org; Sun, 10 Feb 2013 15:36:57 EST From: Krzysztof Halasa To: Joe Perches Cc: netdev@vger.kernel.org, "Jan \"Yenya\" Kasprzak" , Kevin Curtis , linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/8] wan: Remove unnecessary alloc/OOM messages References: <392e9b2c652a41f6c5791268dde1eb8c71d0be90.1359939013.git.joe@perches.com> Date: Sun, 10 Feb 2013 21:30:27 +0100 In-Reply-To: <392e9b2c652a41f6c5791268dde1eb8c71d0be90.1359939013.git.joe@perches.com> (Joe Perches's message of "Sun, 3 Feb 2013 19:28:12 -0800") Message-ID: MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Joe Perches writes: > alloc failures already get standardized OOM > messages and a dump_stack. > > Hoist assigns from if tests. > > Signed-off-by: Joe Perches > --- > drivers/net/wan/cosa.c | 9 ++++----- > drivers/net/wan/farsync.c | 6 ++---- > drivers/net/wan/hdlc.c | 9 ++++----- > drivers/net/wan/x25_asy.c | 1 - > 4 files changed, 10 insertions(+), 15 deletions(-) Good to see. Acked-by: Krzysztof Halasa -- Krzysztof Halasa