From: Christoph Rohland <cr@sap.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org,
"Andreas J. Koenig" <andreas.koenig@anima.de>
Subject: [Patch] correct tmpfs link count for directories
Date: 13 Feb 2001 18:47:43 +0100 [thread overview]
Message-ID: <m3zofq3268.fsf@linux.local> (raw)
Hi Alan,
The attached patch makes tmpfs behave more like other fs's. Apparently
perl expects this.
Greetings
Christoph
diff -uNr 2.4.1-ac10/mm/shmem.c 2.4.1-ac10-nlink/mm/shmem.c
--- 2.4.1-ac10/mm/shmem.c Mon Feb 12 15:01:47 2001
+++ 2.4.1-ac10-nlink/mm/shmem.c Tue Feb 13 13:48:49 2001
@@ -465,6 +465,7 @@
inode->i_fop = &shmem_file_operations;
break;
case S_IFDIR:
+ inode->i_nlink++;
inode->i_op = &shmem_dir_inode_operations;
inode->i_fop = &shmem_dir_operations;
break;
@@ -743,7 +744,12 @@
static int shmem_mkdir(struct inode * dir, struct dentry * dentry, int mode)
{
- return shmem_mknod(dir, dentry, mode | S_IFDIR, 0);
+ int error;
+
+ if ((error = shmem_mknod(dir, dentry, mode | S_IFDIR, 0)))
+ return error;
+ dir->i_nlink++;
+ return 0;
}
static int shmem_create(struct inode *dir, struct dentry *dentry, int mode)
@@ -801,25 +807,21 @@
return 1;
}
-/*
- * This works for both directories and regular files.
- * (non-directories will always have empty subdirs)
- */
static int shmem_unlink(struct inode * dir, struct dentry *dentry)
{
- int retval = -ENOTEMPTY;
+ dentry->d_inode->i_nlink--;
+ dput(dentry); /* Undo the count from "create" - this does all the work */
+ return 0;
+}
- if (shmem_empty(dentry)) {
- struct inode *inode = dentry->d_inode;
+static int shmem_rmdir(struct inode * dir, struct dentry *dentry)
+{
+ if (!shmem_empty(dentry))
+ return -ENOTEMPTY;
- inode->i_nlink--;
- dput(dentry); /* Undo the count from "create" - this does all the work */
- retval = 0;
- }
- return retval;
+ dir->i_nlink--;
+ return shmem_unlink(dir, dentry);
}
-
-#define shmem_rmdir shmem_unlink
/*
* The VFS layer already does all the dentry stuff for rename,
next reply other threads:[~2001-02-13 17:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-13 17:47 Christoph Rohland [this message]
2001-02-13 18:23 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3zofq3268.fsf@linux.local \
--to=cr@sap.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andreas.koenig@anima.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®