From: "H. Peter Anvin" <hpa@zytor.com>
To: Borislav Petkov <borislav.petkov@amd.com>, Ingo Molnar <mingo@elte.hu>
Cc: Andreas Herrmann <herrmann.der.user@googlemail.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH resend] x86, amd: Get multi-node CPU info from NodeId MSR instead of PCI config space
Date: Tue, 15 Dec 2009 12:00:36 -0800 [thread overview]
Message-ID: <mkk2iqhh6vhhmxaxruuvafvb.1260907236343@email.android.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 915 bytes --]
That's nice. It should be in the code, not in the commit message.
"Borislav Petkov" <borislav.petkov@amd.com> wrote:
>On Tue, Dec 15, 2009 at 08:31:50PM +0100, Ingo Molnar wrote:
>>
>> * Andreas Herrmann <herrmann.der.user@googlemail.com> wrote:
>>
>> > + rdmsrl(0xc001100c, value);
>>
>> Dont we want some nice, meaningfully named symbolic constant here, instead of
>> 0xc001100c?
>
>The MSR name is actually in the commit msg, maybe something like
>MSR_F10H_NODE_ID.
>
>--
>Regards/Gruss,
>Boris.
>
>Operating | Advanced Micro Devices GmbH
> System | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany
> Research | Geschäftsführer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
> Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
> (OSRC) | Registergericht München, HRB Nr. 43632
>
--
Sent from my mobile phone. Please excuse any lack of formatting.
next reply other threads:[~2009-12-15 20:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-15 20:00 H. Peter Anvin [this message]
2009-12-15 20:46 ` Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2009-12-15 19:51 H. Peter Anvin
2009-12-15 12:44 Andreas Herrmann
2009-12-15 19:31 ` Ingo Molnar
2009-12-15 19:45 ` Borislav Petkov
2009-10-16 12:22 Andreas Herrmann
2009-10-27 9:33 ` [PATCH RESEND] " Andreas Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mkk2iqhh6vhhmxaxruuvafvb.1260907236343@email.android.com \
--to=hpa@zytor.com \
--cc=borislav.petkov@amd.com \
--cc=herrmann.der.user@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®