From: Johannes Thumshirn <jthumshirn@suse.de>
To: Jack Wang <xjtuwjp@gmail.com>
Cc: lindar_liu <lindar_liu@usish.com>,
"James E.J. Bottomley" <JBottomley@odin.com>,
"pmchba\@pmcs.com" <pmchba@pmcs.com>,
"linux-scsi\@vger.kernel.org" <linux-scsi@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pm80xx: Don't override ts->stat on IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY
Date: Mon, 17 Aug 2015 15:51:08 +0200 [thread overview]
Message-ID: <mqd4mjyowfn.fsf@c203.arch.suse.de> (raw)
In-Reply-To: <CAD+HZHWtvfc1YBM+FdVt1vV8rjkk7GVmX9-NRWXjh=1U4Ez+dg@mail.gmail.com> (Jack Wang's message of "Mon, 17 Aug 2015 15:28:22 +0200")
Jack Wang <xjtuwjp@gmail.com> writes:
> 2015-08-17 15:04 GMT+02:00 Johannes Thumshirn <jthumshirn@suse.de>:
>> In case XXX returns with a status of IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY
Apparently I've hit enter to fast. This shouldn't be XXX but
psataPayload->status. I'll be sending a v2 :-(.
>> ts->stat gets set to SAS_OPEN_REJECT but a missing 'break' statement causes a
>> fallthrough to the default handler of the switch statement overriding ts->stat
>> to SAS_DEV_NO_RESPONSE.
>>
>> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
>
> Thanks, please feel free to add:
> Acked-by: Jack Wang <jinpu.wang@profitbricks.com>
>
>> ---
>> drivers/scsi/pm8001/pm8001_hwi.c | 1 +
>> drivers/scsi/pm8001/pm80xx_hwi.c | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_hwi.c
>> index 96dcc09..d0feec5 100644
>> --- a/drivers/scsi/pm8001/pm8001_hwi.c
>> +++ b/drivers/scsi/pm8001/pm8001_hwi.c
>> @@ -2642,6 +2642,7 @@ mpi_sata_completion(struct pm8001_hba_info *pm8001_ha, void *piomb)
>> ts->resp = SAS_TASK_COMPLETE;
>> ts->stat = SAS_OPEN_REJECT;
>> ts->open_rej_reason = SAS_OREJ_RSVD_RETRY;
>> + break;
>> default:
>> PM8001_IO_DBG(pm8001_ha,
>> pm8001_printk("Unknown status 0x%x\n", status));
>> diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c
>> index 05cce46..18d4ac4 100644
>> --- a/drivers/scsi/pm8001/pm80xx_hwi.c
>> +++ b/drivers/scsi/pm8001/pm80xx_hwi.c
>> @@ -2314,6 +2314,7 @@ mpi_sata_completion(struct pm8001_hba_info *pm8001_ha, void *piomb)
>> ts->resp = SAS_TASK_COMPLETE;
>> ts->stat = SAS_OPEN_REJECT;
>> ts->open_rej_reason = SAS_OREJ_RSVD_RETRY;
>> + break;
>> default:
>> PM8001_IO_DBG(pm8001_ha,
>> pm8001_printk("Unknown status 0x%x\n", status));
>> --
>> 2.5.0
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
prev parent reply other threads:[~2015-08-17 13:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 13:04 Johannes Thumshirn
2015-08-17 13:28 ` Jack Wang
2015-08-17 13:51 ` Johannes Thumshirn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mqd4mjyowfn.fsf@c203.arch.suse.de \
--to=jthumshirn@suse.de \
--cc=JBottomley@odin.com \
--cc=lindar_liu@usish.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=pmchba@pmcs.com \
--cc=xjtuwjp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®