From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751598AbbJBHFM (ORCPT ); Fri, 2 Oct 2015 03:05:12 -0400 Received: from mx2.suse.de ([195.135.220.15]:36296 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751189AbbJBHFK convert rfc822-to-8bit (ORCPT ); Fri, 2 Oct 2015 03:05:10 -0400 From: Johannes Thumshirn To: Rasmus Villemoes Cc: Hiral Patel , Suma Ramars , Brian Uchino , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [SCSI] fnic: use kzalloc in fnic_fcoe_process_vlan_resp References: <1443729543-19362-1-git-send-email-linux@rasmusvillemoes.dk> Date: Fri, 02 Oct 2015 09:05:06 +0200 In-Reply-To: <1443729543-19362-1-git-send-email-linux@rasmusvillemoes.dk> (Rasmus Villemoes's message of "Thu, 1 Oct 2015 21:59:02 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rasmus Villemoes writes: > This saves a little .text and avoids the sizeof(...) style > inconsistency. > > Signed-off-by: Rasmus Villemoes > --- > drivers/scsi/fnic/fnic_fcs.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/scsi/fnic/fnic_fcs.c b/drivers/scsi/fnic/fnic_fcs.c > index bf0bbd42efb5..2d013076bfba 100644 > --- a/drivers/scsi/fnic/fnic_fcs.c > +++ b/drivers/scsi/fnic/fnic_fcs.c > @@ -415,15 +415,13 @@ static void fnic_fcoe_process_vlan_resp(struct fnic *fnic, struct sk_buff *skb) > vid = ntohs(((struct fip_vlan_desc *)desc)->fd_vlan); > shost_printk(KERN_INFO, fnic->lport->host, > "process_vlan_resp: FIP VLAN %d\n", vid); > - vlan = kmalloc(sizeof(*vlan), > - GFP_ATOMIC); > + vlan = kzalloc(sizeof(*vlan), GFP_ATOMIC); > if (!vlan) { > /* retry from timer */ > spin_unlock_irqrestore(&fnic->vlans_lock, > flags); > goto out; > } > - memset(vlan, 0, sizeof(struct fcoe_vlan)); > vlan->vid = vid & 0x0fff; > vlan->state = FIP_VLAN_AVAIL; > list_add_tail(&vlan->list, &fnic->vlans); Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850