From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751674AbbGIGsx (ORCPT ); Thu, 9 Jul 2015 02:48:53 -0400 Received: from cantor2.suse.de ([195.135.220.15]:50843 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750955AbbGIGsq convert rfc822-to-8bit (ORCPT ); Thu, 9 Jul 2015 02:48:46 -0400 From: Johannes Thumshirn To: Greg Kroah-Hartman Cc: "Hans J. Koch" , linux-kernel@vger.kernel.org, Johannes Thumshirn Subject: Re: [PATCH] uio: Destroy uio_idr on module exit References: <1436369086-31231-1-git-send-email-jthumshirn@suse.de> <20150708172430.GA14727@kroah.com> Date: Thu, 09 Jul 2015 08:48:36 +0200 In-Reply-To: <20150708172430.GA14727@kroah.com> (Greg Kroah-Hartman's message of "Wed, 8 Jul 2015 10:24:30 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg Kroah-Hartman writes: > On Wed, Jul 08, 2015 at 05:24:46PM +0200, Johannes Thumshirn wrote: >> Destroy uio_idr on module exit, reclaiming the allocated memory. >> >> This was detected by the following semantic patch (written by Luis Rodriguez >> ) >> >> @ defines_module_init @ >> declarer name module_init, module_exit; >> declarer name DEFINE_IDR; >> identifier init; >> @@ >> >> module_init(init); >> >> @ defines_module_exit @ >> identifier exit; >> @@ >> >> module_exit(exit); >> >> @ declares_idr depends on defines_module_init && defines_module_exit @ >> identifier idr; >> @@ >> >> DEFINE_IDR(idr); >> >> @ on_exit_calls_destroy depends on declares_idr && defines_module_exit @ >> identifier declares_idr.idr, defines_module_exit.exit; >> @@ >> >> exit(void) >> { >> ... >> idr_destroy(&idr); >> ... >> } >> >> @ missing_module_idr_destroy depends on declares_idr && defines_module_exit && !on_exit_calls_destroy @ >> identifier declares_idr.idr, defines_module_exit.exit; >> @@ >> >> exit(void) >> { >> ... >> +idr_destroy(&idr); >> } >> >> >> >> Signed-off-by: Johannes Thumshirn > > Nice work. Shouldn't we do the same thing for ida_destroy() as well? I > see 4 USB drivers that need this same fix for that structure. > Can you tell me which? I've send overall 13 patches for this (no series as get_maintainers.pl for the series spit out > 30 Recipients so I refused to send spam). Maybe/probably I forgot one (or two). Johannes -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)