From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752264AbbJFMI3 (ORCPT ); Tue, 6 Oct 2015 08:08:29 -0400 Received: from mx2.suse.de ([195.135.220.15]:51288 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751340AbbJFMI1 convert rfc822-to-8bit (ORCPT ); Tue, 6 Oct 2015 08:08:27 -0400 From: Johannes Thumshirn To: Jiri Slaby Cc: akpm@linux-foundation.org, JBottomley@Odin.com, kxie@chelsio.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -resend_2 1/1] cxgbi: fix build with EXTRA_CFLAGS References: <1444131587-28749-1-git-send-email-jslaby@suse.cz> Date: Tue, 06 Oct 2015 14:08:25 +0200 In-Reply-To: <1444131587-28749-1-git-send-email-jslaby@suse.cz> (Jiri Slaby's message of "Tue, 6 Oct 2015 13:39:47 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jiri Slaby writes: > EXTRA_CFLAGS are intended to be used on the command line, not by > Kbuild. In case of cxgbi drivers, use of EXTRA_CFLAGS results in a > compilation failure: > drivers/scsi/cxgbi/cxgb4i/cxgb4i.c:24:21: fatal error: t4_regs.h: No such file or directory > when building like: > $ make drivers/scsi/cxgbi/ EXTRA_CFLAGS=-Wwhatever > > Use ccflags-y instead of EXTRA_CFLAGS. > > Signed-off-by: Jiri Slaby > --- > Sent on: > Sep 10 > Jun 9 > > drivers/scsi/cxgbi/cxgb3i/Kbuild | 2 +- > drivers/scsi/cxgbi/cxgb4i/Kbuild | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/cxgbi/cxgb3i/Kbuild b/drivers/scsi/cxgbi/cxgb3i/Kbuild > index 6f095e28a974..961a12f6d318 100644 > --- a/drivers/scsi/cxgbi/cxgb3i/Kbuild > +++ b/drivers/scsi/cxgbi/cxgb3i/Kbuild > @@ -1,3 +1,3 @@ > -EXTRA_CFLAGS += -I$(srctree)/drivers/net/ethernet/chelsio/cxgb3 > +ccflags-y += -I$(srctree)/drivers/net/ethernet/chelsio/cxgb3 > > obj-$(CONFIG_SCSI_CXGB3_ISCSI) += cxgb3i.o > diff --git a/drivers/scsi/cxgbi/cxgb4i/Kbuild b/drivers/scsi/cxgbi/cxgb4i/Kbuild > index 8290cdaa4652..37458643749b 100644 > --- a/drivers/scsi/cxgbi/cxgb4i/Kbuild > +++ b/drivers/scsi/cxgbi/cxgb4i/Kbuild > @@ -1,3 +1,3 @@ > -EXTRA_CFLAGS += -I$(srctree)/drivers/net/ethernet/chelsio/cxgb4 > +ccflags-y += -I$(srctree)/drivers/net/ethernet/chelsio/cxgb4 > > obj-$(CONFIG_SCSI_CXGB4_ISCSI) += cxgb4i.o Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850