From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751704AbcFUJNQ (ORCPT <rfc822;w@1wt.eu>);
	Tue, 21 Jun 2016 05:13:16 -0400
Received: from mx2.suse.de ([195.135.220.15]:56725 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750998AbcFUJNL (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 21 Jun 2016 05:13:11 -0400
From: Andreas Schwab <schwab@suse.de>
To: Yury Norov <ynorov@caviumnetworks.com>
Cc: <libc-alpha@sourceware.org>, <linux-kernel@vger.kernel.org>,
        <arnd@arndb.de>, <catalin.marinas@arm.com>, <marcus.shawcroft@arm.com>,
        <philb@gnu.org>, <davem@davemloft.net>, <szabolcs.nagy@arm.com>,
        <maxim.kuvyrkov@linaro.org>, <joseph@codesourcery.com>,
        <pinskia@gmail.com>, Andrew Pinski <apinski@cavium.com>
Subject: Re: [PATCH 04/27] [AARCH64] Add PTR_REG, PTR_LOG_SIZE, and PTR_SIZE.  Use it in LDST_PCREL and LDST_GLOBAL.
References: <1466485631-3532-1-git-send-email-ynorov@caviumnetworks.com>
	<1466485631-3532-6-git-send-email-ynorov@caviumnetworks.com>
	<mvmporbrn7c.fsf@hawking.suse.de>
X-Yow: The PINK SOCKS were ORIGINALLY from 1952!!
 But they went to MARS around 1953!!
Date: Tue, 21 Jun 2016 11:13:09 +0200
In-Reply-To: <mvmporbrn7c.fsf@hawking.suse.de> (Andreas Schwab's message of
	"Tue, 21 Jun 2016 09:54:47 +0200")
Message-ID: <mvm60t2rjkq.fsf@hawking.suse.de>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Andreas Schwab <schwab@suse.de> writes:

>> +/* Load or store to/from a got-relative EXPR into/from R, using T.
>> +   Note R and T are register numbers and not register names.  */
>> +#define LDST_GLOBAL(OP, R, T,  EXPR)			\
>> +	adrp	x##T, :got:EXPR;			\
>> +	ldr	PTR_REG (T), [x##T, #:got_lo12:EXPR];	\
>> +	OP	x##R, [x##T];
>
> I think this needs to be PTR_REG(x).

I mean PTR_REG(R), of course.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."