From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF3AD30CD92 for ; Tue, 7 Jul 2026 14:47:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783435656; cv=none; b=Is4M0+7p86HY98GYnGv1CcdVH36jAcOBEY6uMCiP2iDv+fFlbcbaaQqm9FE1v8+NkpTZ+poNLspnC3CTcXYKGv2AkG2tJD6sWu3jskSGk1vK/5Kw2QTBxXVwMlyskg3l4va6FU4sDqcrTjHK6h6VUyRVRGQ1BQ+Ml+CUxQxnrfY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783435656; c=relaxed/simple; bh=kbB/eBRZgg8WpEohJaYOhBTmcXDJ4/L3JhRiQEfaGtQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jdBdlczQotR/RfQIL7WUdcGBrEJsOEgaX+2Jyp0I9G/N9y6WKrsAhOszpyvnVHwoTcuKL+HQ/mXoS0xU6BLuwsQaj1L/NN7UXskrlH8nJiuTVrCpxkXIDoVxmZ0hyhqx15vaIu7w6sJkT+Meja36gG6boYcu2QOz0j9qlTolvB4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=p0NaCsYi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Xe8/rre3; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="p0NaCsYi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Xe8/rre3" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 667C8x1d3719215 for ; Tue, 7 Jul 2026 14:47:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KnL8n0Rge/PLupFS9hJ3iC3ksta3Fq+O1fWOUkKJBYc=; b=p0NaCsYiWC2KqUWR XSBHszC+Ja+g2ZwIFWFp9g/5FUjNwtQge9XqWfGw6sW30HCuKbAVoLt6Zy+QWHP3 ftQZh+j4LdrRwvXnqWqSmC6ffC3xGv149tGagUZ+kTHCUgN2WJwb9bnOI0Dn1zjL NWG+IOy3dukl+KbAcIIsdjUICVoSAB2LM/O0zkRnw30JEX1i64BDnjW0381vjvq8 QUYatQAS9+jYcCJ3+QU1kNE/TYSSrO4DN1MQxpYOOmMf+yCw0cfk28xYDTRKD2E8 XEt12NOYzcWGIwnZBq6BGVxpHUrUhbvKSomzQuJUaSTz7/tpDIwCsr98Lb2dLwUo MmeSEA== Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f8v3ta2c9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Jul 2026 14:47:33 +0000 (GMT) Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-73850dfc198so1014829137.2 for ; Tue, 07 Jul 2026 07:47:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783435653; x=1784040453; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=KnL8n0Rge/PLupFS9hJ3iC3ksta3Fq+O1fWOUkKJBYc=; b=Xe8/rre36zyRiCRZTFr2gHVTrIKrhLTF2t0CuJQw+1nCuzUQkrBM+7hpMXQzBAp+PH amAuVJyd7qzWksmwPoBiNgd8AnZgszQIPYxXaMX+yAeQdTafaMB/F4iRjHIq7YdLpz7K +JaYpOIUz5iz4HEYoVoh5wSyP+D+Au7ECd1YXZWU+aQ7lDRbleRx+N7g26IH9DKQ0ArE WUcaopy7yGmj34dOgvEgejfavluZbAo2enDwvm2knq2Bn+65Ve9teByUDF7UF7upLW++ ugvSTR8WcHYlXzc9xHeO7/hCrEvMRib+TXRoS5ADAVFAARbKlgIrYluyz/E9Ji/k6nlr WL9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783435653; x=1784040453; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KnL8n0Rge/PLupFS9hJ3iC3ksta3Fq+O1fWOUkKJBYc=; b=nibayC9irU3CGmrEzO9RIMG7mSATrNRNzx2Wp+HLwZlTHtT+F4uKzh+fJtS+l5Nrjn 0q57YCk/Olcc/SOS+4lLNLfSgKBrHWpKGzidaVGumEnmf/2m8Tn3k2/8TeuEt/2MF1sK Cc7IxAlLzYfg0hVVg/hbUQzYxpFpTWGjuCuJemBPB2RFsOqwnAJYT7f9HPMLU985SYwe EcylNrLTHb2Zdn2L7esZoIzijYh+dvSkPq9HzKacMk6yWxw2iUF28IoGuRro7kwL4cql fN22XuvVitYMAtgoFLBlrZ/LAA4PRwKQEUFPrjGPltPzUPo8kQLr45b8PhtP9Eexble/ bhEA== X-Forwarded-Encrypted: i=1; AHgh+RpsRlty+FLNlxTmRQAzzBz4pJbr+cOsJziSJvcGvQBvCfWR1uwxbo1ogdfAxwZEvbIQjJ2KynCFxUNQd+o=@vger.kernel.org X-Gm-Message-State: AOJu0YzCWz0kMjPg8iDA13pCtgucXPO8FK5mNKRxshnTYsd1+SrqJCDN l+6tM2/0UzApeRaP0PKQdb0zIzv04/mx/o1Qxo5ENkyE7kez7Ml0i7gbP/ieBG9EFNl4oh9+m3d RsOWI6u/z55DpIo5h3ZRMQfRSiSkhtYXWKgHEYuiLwaTeAU1kQtkiEzPOpFR4hFoZ66U= X-Gm-Gg: AfdE7clhoOtPZ+gkiMyQYo18n4p1ozm/gn+DwcOpDa0hKZMRalhLHmDvk6huqjFjqf4 XukXsQElBuJHJjaearHFcYIjsmTCfsvA+ydC8jUQPiFcjwrgAaj2MS6N4EgkSGBuaUSdE5Tloe2 uXFH2qm1L/xnarceBMJM5n2aUH1CV9gcA/20OBznFvkHAwy6R92ZnsvlYXD1sgz3Cc+nbb581Dz 5FT4HE1BR7puFZ5C0YaGDWxXKhSvQcJ3Wbm/ZQS8QkJZacSiH6AHfnAFZEt3NXmSAVBN32Y8pdS lxzQZZqKjpn1RGHfvjjXTqz5NtHUmG1NY3++DB/Q//JQcXQ3g3tChPP7vhCX39SIFsIAkzU0v2t 0VEhFAma1WoZ7bD4MSyDTcanhaoQ9rQEEKNIBmx/+rq2yP2CXbyC7APZ98D41JoQ3YfPD8Zpixg HUGWCUIIbpkETwsY++a+JmlmTF X-Received: by 2002:a05:6102:6448:b0:726:cd42:d023 with SMTP id ada2fe7eead31-744b7a8eb73mr3208759137.11.1783435653030; Tue, 07 Jul 2026 07:47:33 -0700 (PDT) X-Received: by 2002:a05:6102:6448:b0:726:cd42:d023 with SMTP id ada2fe7eead31-744b7a8eb73mr3208733137.11.1783435652469; Tue, 07 Jul 2026 07:47:32 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39b4ad35edfsm29360981fa.13.2026.07.07.07.47.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 07:47:31 -0700 (PDT) Date: Tue, 7 Jul 2026 17:47:29 +0300 From: Dmitry Baryshkov To: "Gjorgji Rosikopulos (Consultant)" Cc: Vladimir Zapolskiy , Atanas Filipov , linux-media@vger.kernel.org, bryan.odonoghue@linaro.org, loic.poulain@oss.qualcomm.com, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 5/5] media: qcom: jpeg: Add Qualcomm JPEG V4L2 encoder Message-ID: References: <20260706071113.383215-1-atanas.filipov@oss.qualcomm.com> <20260706071113.383215-6-atanas.filipov@oss.qualcomm.com> <51a0abf2-2a72-4551-894b-2c2de91ba0c2@linaro.org> <74a5b549-987c-4dac-a1a0-ff81150cd6ab@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Proofpoint-GUID: xLcQ4G12hRwVsNdlwalpyMW8GvXhlT0s X-Proofpoint-ORIG-GUID: xLcQ4G12hRwVsNdlwalpyMW8GvXhlT0s X-Authority-Analysis: v=2.4 cv=HqVG3UTS c=1 sm=1 tr=0 ts=6a4d1185 cx=c_pps a=P2rfLEam3zuxRRdjJWA2cw==:117 a=xqWC_Br6kY4A:10 a=8nJEP1OIZ-IA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=gfVf64230eWH3T0bUGYA:9 a=3ZKOabzyN94A:10 a=wPNLvfGTeEIA:10 a=ODZdjJIeia2B_SHc_B0f:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA3MDE0MyBTYWx0ZWRfXzRLqgMYfdrTM NXzCdMj4nCUlCAf7yIZkxWRLghhfOQO8zqRRhOqxiz8kiXH+VY16Y7xGKnQbLs6WtC+bcfU5j+Y SkUWYjJWwOYWN5LtKnUJk7F24nGrmSvI5jU5FZpr/4fT0O3kkn+J92ZBEhDTZizQg4y3kw9+8LF QWSzK05MkZnd6e29YLWeJwjNYnebI7rd7vlG8q6ntKlc/0Gr4ln7bxw9kjTtpZrq+uM1CU+v4Yo vmiGrT+bVQRhgr2IoEQ4sZhVm6JEkFuKfCcI6Ayfr3jab3E4710ykJBxa4oQgDqKM1IKGXhK4+/ IQARTlaYRX1R6FsoQl6rsTp3ima+bSTII07SXy0mjiyNtsUY5nIRztWggPGiWaYdnKf7SvFNLbo qQeut4+NiGHEe8BZyVBihW0T6jkcanw4V24dJn6JzTw3XEkzbC5aT+b/Zn34vqXZ5SNp0rxfbbg ux32ediIebKElAxy1tw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA3MDE0MyBTYWx0ZWRfXwXdf05wqjQXm IHkCAmcUcEnQoC0ON4RhlfhguZCsDMgHxSFNCNOZE3OtY5i+ZsSucvPa0rbemTvjTVwb2T9Q3jx 6WpOL0bNrF8bxep5kWgg6GcNh3VWjek= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-07_03,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 adultscore=0 suspectscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607070143 On Tue, Jul 07, 2026 at 04:47:07PM +0300, Gjorgji Rosikopulos (Consultant) wrote: > Hi Dmitry, > > On 7/7/2026 4:32 PM, Dmitry Baryshkov wrote: > > On Tue, Jul 07, 2026 at 04:24:19PM +0300, Gjorgji Rosikopulos (Consultant) wrote: > >> Hi Vlad, > >> > >> On 7/6/2026 10:46 AM, Vladimir Zapolskiy wrote: > >> > >>>> > >>>> +            interconnects = <&gem_noc MASTER_AMPSS_M0 > >>>> QCOM_ICC_TAG_ACTIVE_ONLY > >>>> +                             &config_noc SLAVE_CAMERA_CFG > >>>> QCOM_ICC_TAG_ACTIVE_ONLY>, > >>>> +                            <&mmss_noc MASTER_CAMNOC_HF > >>>> QCOM_ICC_TAG_ALWAYS > >>>> +                             &mc_virt SLAVE_EBI_CH0 > >>>> QCOM_ICC_TAG_ALWAYS>, > >>>> +                            <&mmss_noc MASTER_CAMNOC_SF > >>>> QCOM_ICC_TAG_ALWAYS > >>>> +                             &mc_virt SLAVE_EBI_CH0 > >>>> QCOM_ICC_TAG_ALWAYS>; > >>>> +            interconnect-names = "cpu-cfg", > >>>> +                                 "hf-mnoc", > >>>> +                                 "sf-mnoc"; > >>> > >>> This is the topic, which may raise a disagreement, but I'll repeat my > >>> position about the need to remove all "CAMSS bus" specific resources from > >>> the device node, they are found and should be allocated on parent's side. > >> > >> The interconnect has functionality to handle bw requests from different > >> clients. > >> > >> Yes the best will be to have camss interconnect, so jpeg and other hw's to > >> vote > >> > >> on that (actually it is possible in icc framework) but what is the benefit > >> of moving > >> > >> those to camss? Is it not better to create camss icc. I understand > > > > Please fix your email client and stop inserting extra empty lines. > Apologies for that. Some Thunderbird settings were missing on my side, i hope now is fine...> > >> > >> you want them to be on parent side. But how to vote on bw? Most of the time > >> it > > > > If the driver actually votes on those, I think, it should be fine. This > > patchset seemed to add bandwidth voting, but then it dropped all the > > votes in the last commit. > > > >> > >> depends on the jpeg encoder configuration based on resolution format etc. to > >> set properly average bw. > >> > >> So i dont see how that can be done with not explicit dependency on jpeg with > >> camss and some exported > >> > >> API's which we discussed with Bryan they are preferable. > > > > Interconnects should be fine to be referenced here. Especially, if JPEG > > has its own port to those busses (hint, commit message). > > > > As I wrote, I see a bigger issue with the clocks. You need to have some > > API to vote on them (and then let camss driver aggregate those votes in > > a platform-specific manner). > Can we use icc-clk framework to vote on them. I think even today there may be some issues in camss > for the clock voting. Please discuss it with the Camera team, working on the camss improvements. -- With best wishes Dmitry