From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDACE37DEA4 for ; Fri, 3 Jul 2026 06:27:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783060056; cv=none; b=ZUFUScoCTS5BhbNyl0VCPc3TMCgNHE1d/xLrwMtyfZNwZkiDICNB7FEc7lmI3VDQTtZ4gWnxMTUP6tu8nnxynYSz1ZRhqUUY5A/KPPSxT+aXU3vhBO80cyYBiyQjcfyu8WXGgquEE+EFFPjderq7pwEUoUibeEhyqi7nGBaSdM8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783060056; c=relaxed/simple; bh=EWc1b5nXZoq0OiHRf8WoqYanyHC84gIAhCmWZlWUj4c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=W9S/2FlFz/bAWdVSb2jWB9BmEzhMm4EY0S8EL5PiCXZLPWi3lidjgkwWnKbYVVAcPSVLzuqFxh3dapf+u8bVtGQV9L2E43tVF6qn4BO10IjeXXfO2WSwR6P2QiXHdkm+8LYuBnToGPWoG0bhTmV4kmzx8e7pxxl+hQ0xxUixfHs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=iAxtkaHi; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iAxtkaHi" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-380cda7f00cso215028a91.0 for ; Thu, 02 Jul 2026 23:27:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1783060051; x=1783664851; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=aQ7ByzFqI/4JyRD3MlNQLQW2E98MhssCvFL4d65wbGM=; b=iAxtkaHi+DThfFTEqJ2a/XedULzsnKnAe7PSflJK3NoPPqNWuPHdmWBGR/uGEfmGMT JehvUqV6xWgbUP1rVkgP/WBYMasOa/3qk6tYg2AXx0SHT8JJk+3+JCsRLRn3plriw2jP eOwT/epTkMM3iy5RKJR0N8mFss2BtBS85X7VOd1tbyIFy7rSsCn40RrMA/ltZhwQFCmr dAY3YGh66TURjHWo4Hh0XUP78Uzr25MWtKmTiV7BJb0Vs2L1uXfq0dJn3+T5n6kC87Ko v17NK13If6a6aggWePfmpfa839KjYMtoVJhtMgYmudXvLKycNkapoHKJcRFF/Fj/juBt NbBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783060051; x=1783664851; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aQ7ByzFqI/4JyRD3MlNQLQW2E98MhssCvFL4d65wbGM=; b=XTpyPgps27NAQ1lZZTBoSdsH6gTJiYhmmz0nS6rwpc5NwHJFEg4QMAYa1oMJFWZaRd +2k/OHlEjmBNXpIkjhUDdIAHCUXx73wtqJNc1rRXBN91xBu+lDWlGuIw7FY7dp1G3mPq hqwtf1NdsrXtNAe15Cv/A+v1UdEsacBTw3iMxhIWt7oHO/Rlxbgg8fBMpnZrnpDozLzK my2I223pR0urCtkTLZch5MeIxlHtq6ISOQ6TE2r79/YFXkOcvVdFtK7q4y1+MmFjHtcw MZFmSZenAAkhgg/Ax1x6LNIWwhjNLocQuB80aBcCOyZhJk6jcIPQs1HmGRH+zjjxwtki TNUg== X-Forwarded-Encrypted: i=1; AHgh+RrLBj2yH68Dumy7U8tBS8XnPlmGHW3HKlcg3jL1A+fiqUQd1vnw/h6ZM6oA6lbW3/LeXF+UrkbTNiHgnTc=@vger.kernel.org X-Gm-Message-State: AOJu0YxE5yWMZJrDwSCyjdrP8Dh/32MzeM6Q7cyqcRGQy5PB7wDvaquc LeuzNPmf2cjJZ2s6VXJyGPIMFkJhx91IzTV7OXCQimWynPXiryIN0qpln3wUOrYmmVo= X-Gm-Gg: AfdE7ckkhIOR0lta+FfQ/591BrVeqHNDeF4BsU8gd0cwHkyM1Yidm8A8v2z5nlduPMr Di1zMB4zlovcGTCBCNU2OdtI6pYe+e7dklwMdJX5brogwkqrAb+ShTYYazjoXh8qtf1amTXPV7o A5WdcwRpsta74nYYWMhqo1ksCULIJUNqDw5mekBQw5Z3lmmiOAmSOWGv1tALLRkejkNlpoAYQ2U KCKaCnKILODs0lsntor7JzPQTvte4mmgs6GD2aMYSDBzmEHpLFsr8L2ObqgDR1OSy78KPYK8zu5 O7ttyJlmlaYYW6TXhNqYWakQT+txgPutrYrcWAVPPTlVUFvJUsR+qahnKow/aCX+/+GGMRYq61L qqs5rXufhAfhWW7McXzB7mpAiG7h42BQb+gmMExsE62RLtzxQIoMkFQjqR+6Mjf2ZLsnkqQNNDu IaZP47FRuSFVY5 X-Received: by 2002:a17:90b:3943:b0:37f:b447:def8 with SMTP id 98e67ed59e1d1-380baa8eaf9mr8701638a91.25.1783060050885; Thu, 02 Jul 2026 23:27:30 -0700 (PDT) Received: from localhost ([122.172.82.94]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f0b813cd9sm15733594eec.8.2026.07.02.23.27.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 23:27:29 -0700 (PDT) Date: Fri, 3 Jul 2026 11:57:27 +0530 From: Viresh Kumar To: Haoxiang Li Cc: sven@kernel.org, j@jannau.net, neal@gompa.dev, rafael@kernel.org, marcan@marcan.st, maz@kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3] cpufreq: apple-soc: Fix OPP table cleanup Message-ID: References: <20260703062049.1459175-1-haoxiang_li2024@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260703062049.1459175-1-haoxiang_li2024@163.com> On 03-07-26, 14:20, Haoxiang Li wrote: > apple_soc_cpufreq_init() adds OPP tables from firmware, but > some failure paths do not remove them. The driver also uses > dev_pm_opp_remove_all_dynamic(), which is not the right cleanup > helper for OPP tables loaded from firmware. > > Use the cpumask OPP helper after the policy CPU mask has been > populated. Pair it with the matching cpumask remove helper on > failure paths and in apple_soc_cpufreq_exit(). This also removes > the separate dev_pm_opp_set_sharing_cpus() call, as the cpumask > helper loads the DT OPP tables for all CPUs in the policy. > > Fixes: 6286bbb40576 ("cpufreq: apple-soc: Add new driver to control Apple SoC CPU P-states") > Cc: stable@vger.kernel.org > Signed-off-by: Haoxiang Li > --- > Changes in v2: > - Remove unnecessary cleanup calls. > - Remove OPP table from apple_soc_cpufreq_exit(). Thanks, Viresh! > Changes in v3: > - Add Fixes and Cc stable tags. > - Use cpumask OPP helpers. > - Reorder init and failure cleanup. Thanks, Viresh! > --- > drivers/cpufreq/apple-soc-cpufreq.c | 36 +++++++++++------------------ > 1 file changed, 14 insertions(+), 22 deletions(-) Applied. Thanks. -- viresh