From: Jiri Kosina <jikos@kernel.org>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: David Barksdale <dbarksdale@uplogix.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: cp2112: prevent sleeping function called from invalid context
Date: Mon, 19 Aug 2019 14:13:35 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.1908191413200.27147@cbobk.fhfr.pm> (raw)
In-Reply-To: <20190812160444.10402-1-benjamin.tissoires@redhat.com>
On Mon, 12 Aug 2019, Benjamin Tissoires wrote:
> When calling request_threaded_irq() with a CP2112, the function
> cp2112_gpio_irq_startup() is called in a IRQ context.
>
> Therefore we can not sleep, and we can not call
> cp2112_gpio_direction_input() there.
>
> Move the call to cp2112_gpio_direction_input() earlier to have a working
> driver.
>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Pushed out to for-5.3/upstream-fixes.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2019-08-19 12:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 16:04 Benjamin Tissoires
2019-08-19 12:13 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.1908191413200.27147@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=dbarksdale@uplogix.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®