From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E127EC83007 for ; Wed, 29 Apr 2020 19:47:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3FB0206B8 for ; Wed, 29 Apr 2020 19:47:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588189645; bh=imdDb6SEe8egaE3DWtE90vcKygzMU7wmOuUhdRPk8zY=; h=Date:From:To:cc:Subject:In-Reply-To:References:List-ID:From; b=l4BS3O3qMZUdM6lV1xXlKKcdLi8fQKzr9MOAeZ8OwzAJTJsGk+mP7h7fI3k6NActm O9On3aLZEU5kPzVpWOx+eapGjopo5vUsgoZBNz+3CsBlNJv4ddaj2DF36HxiMlt7YC nm9B7TOl/Ryp11ut0wVkFdeupFKhAIq3b+z2Lr78= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727839AbgD2TrY (ORCPT ); Wed, 29 Apr 2020 15:47:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:48130 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727811AbgD2TrP (ORCPT ); Wed, 29 Apr 2020 15:47:15 -0400 Received: from pobox.suse.cz (unknown [195.250.132.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EB36120BED; Wed, 29 Apr 2020 19:47:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588189635; bh=imdDb6SEe8egaE3DWtE90vcKygzMU7wmOuUhdRPk8zY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=bN0B9f6iw/MfZp7uh/2hFkPjkJeuedU1Yd0zv33xUVg/SOOcYKIQp+zIFOEQN1eEm sCeux0tPex7kTp7ewfQBWL/e5iN9qn9XlQSFYIvvdoVKzj0pbkIXTxa+iyvnLDeZve Sa0O882EPvX4uUtIWkaEYwJqN5NHmV0hKeIZhIDM= Date: Wed, 29 Apr 2020 21:47:12 +0200 (CEST) From: Jiri Kosina To: Arnd Bergmann cc: Benjamin Tissoires , Rishi Gupta , Linus Walleij , Bastien Nocera , Dmitry Torokhov , Wolfram Sang , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: mcp2221: add gpiolib dependency In-Reply-To: <20200428213035.3108649-1-arnd@arndb.de> Message-ID: References: <20200428213035.3108649-1-arnd@arndb.de> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Apr 2020, Arnd Bergmann wrote: > Without gpiolib, this driver fails to link: > > arm-linux-gnueabi-ld: drivers/hid/hid-mcp2221.o: in function `mcp2221_probe': > hid-mcp2221.c:(.text+0x1b0): undefined reference to `devm_gpiochip_add_data' > arm-linux-gnueabi-ld: drivers/hid/hid-mcp2221.o: in function `mcp_gpio_get': > hid-mcp2221.c:(.text+0x30c): undefined reference to `gpiochip_get_data' > > Fixes: 328de1c519c5 ("HID: mcp2221: add GPIO functionality support") > Signed-off-by: Arnd Bergmann Applied, thanks Arnd. -- Jiri Kosina SUSE Labs