mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Kosina <jikos@kernel.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: WANG Wenhu <wenhu.wang@vivo.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Allison Randal <allison@lohutok.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	wenhu.pku@gmail.com
Subject: Re: [PATCH] powerpc/sysdev: fix compile errors
Date: Mon, 18 May 2020 12:29:37 +0200 (CEST)	[thread overview]
Message-ID: <nycvar.YFH.7.76.2005181228480.25812@cbobk.fhfr.pm> (raw)
In-Reply-To: <62251ec1-dd42-6522-dcb2-613838cd5504@c-s.fr>

On Mon, 2 Mar 2020, Christophe Leroy wrote:

> > Include linux/io.h into fsl_85xx_cache_sram.c to fix the
> > implicit-declaration compile errors when building Cache-Sram.
> > 
> > arch/powerpc/sysdev/fsl_85xx_cache_sram.c: In function
> > ‘instantiate_cache_sram’:
> > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:26: error: implicit declaration
> > of function ‘ioremap_coherent’; did you mean ‘bitmap_complement’?
> > [-Werror=implicit-function-declaration]
> >    cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
> >                            ^~~~~~~~~~~~~~~~
> >                            bitmap_complement
> > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:24: error: assignment makes
> > pointer from integer without a cast [-Werror=int-conversion]
> >    cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
> >                          ^
> > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:123:2: error: implicit declaration
> > of function ‘iounmap’; did you mean ‘roundup’?
> > [-Werror=implicit-function-declaration]
> >    iounmap(cache_sram->base_virt);
> >    ^~~~~~~
> >    roundup
> > cc1: all warnings being treated as errors
> > 
> > Fixed: commit 6db92cc9d07d ("powerpc/85xx: add cache-sram support")
> > Signed-off-by: WANG Wenhu <wenhu.wang@vivo.com>
> 
> Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>

As this doesn't seem to have been picked up for linux-next yet, I am 
picking it up now.

Thanks,

-- 
Jiri Kosina
SUSE Labs


  reply	other threads:[~2020-05-18 10:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-02  5:37 WANG Wenhu
2020-03-02  6:38 ` Christophe Leroy
2020-05-18 10:29   ` Jiri Kosina [this message]
2020-05-18 10:32     ` Jiri Kosina
2020-05-18 10:36       ` Christophe Leroy
2020-05-18 11:37       ` Michael Ellerman
  -- strict thread matches above, loose matches on Subject: below --
2020-01-21  6:59 王文虎
2020-01-21  8:21 ` Christophe Leroy
2020-01-21  8:37 ` Christophe Leroy
2020-01-21  5:31 wangwenhu
2020-01-21  5:58 ` Christophe Leroy
2020-01-21  6:13 ` Andrew Donnellan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.YFH.7.76.2005181228480.25812@cbobk.fhfr.pm \
    --to=jikos@kernel.org \
    --cc=allison@lohutok.net \
    --cc=benh@kernel.crashing.org \
    --cc=christophe.leroy@c-s.fr \
    --cc=gregkh@linuxfoundation.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    --cc=tglx@linutronix.de \
    --cc=wenhu.pku@gmail.com \
    --cc=wenhu.wang@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®