From: Jiri Kosina <jikos@kernel.org>
To: Xiaofei Tan <tanxiaofei@huawei.com>
Cc: benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, hdegoede@redhat.com,
kai.heng.feng@canonical.com, vicamo.yang@canonical.com,
daniel.playfair.cal@gmail.com, admin@kryma.net,
linuxarm@huawei.com
Subject: Re: [PATCH] HID: i2c-hid: fix some doc warnings in i2c-hid-core.c
Date: Wed, 23 Sep 2020 13:11:30 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2009231311250.3336@cbobk.fhfr.pm> (raw)
In-Reply-To: <1600776484-31742-1-git-send-email-tanxiaofei@huawei.com>
On Tue, 22 Sep 2020, Xiaofei Tan wrote:
> Fix following warnings caused by mismatch bewteen function parameters
> and comments.
> drivers/hid/i2c-hid/i2c-hid-core.c:331: warning: Function parameter or member 'data_len' not described in 'i2c_hid_set_or_send_report'
> drivers/hid/i2c-hid/i2c-hid-core.c:331: warning: Excess function parameter 'len' description in 'i2c_hid_set_or_send_report'
>
> Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
> ---
> drivers/hid/i2c-hid/i2c-hid-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
> index dbd0449..01e9b36 100644
> --- a/drivers/hid/i2c-hid/i2c-hid-core.c
> +++ b/drivers/hid/i2c-hid/i2c-hid-core.c
> @@ -323,7 +323,7 @@ static int i2c_hid_get_report(struct i2c_client *client, u8 reportType,
> * @reportType: 0x03 for HID_FEATURE_REPORT ; 0x02 for HID_OUTPUT_REPORT
> * @reportID: the report ID
> * @buf: the actual data to transfer, without the report ID
> - * @len: size of buf
> + * @data_len: size of buf
> * @use_data: true: use SET_REPORT HID command, false: send plain OUTPUT report
Applied.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2020-09-23 11:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 12:08 Xiaofei Tan
2020-09-23 11:11 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2009231311250.3336@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=admin@kryma.net \
--cc=benjamin.tissoires@redhat.com \
--cc=daniel.playfair.cal@gmail.com \
--cc=hdegoede@redhat.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=tanxiaofei@huawei.com \
--cc=vicamo.yang@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®