mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Kosina <jikos@kernel.org>
To: Sandeep Singh <Sandeep.Singh@amd.com>
Cc: benjamin.tissoires@redhat.com, linux-kernel@vger.kernel.org,
	linux-input@vger.kernel.org, jic23@kernel.org,
	Nehal-bakulchandra.Shah@amd.com, mail@richard-neumann.de,
	Shyam-sundar.S-k@amd.com, lipheng@hanmail.net
Subject: Re: [PATCH v3] AMD_SFH: Fix for incorrect Sensor index
Date: Thu, 29 Oct 2020 16:03:16 +0100 (CET)	[thread overview]
Message-ID: <nycvar.YFH.7.76.2010291602550.18859@cbobk.fhfr.pm> (raw)
In-Reply-To: <20201028090010.2689060-1-Sandeep.Singh@amd.com>

On Wed, 28 Oct 2020, Sandeep Singh wrote:

> From: Sandeep Singh <sandeep.singh@amd.com>
> 
> It appears like the accelerometer/magnetometer and gyroscope
> indices were interchanged in the patch series which got into
> for-5.11/amd-sfh-hid until Mandoli/Richard reported to us.
> Ideally sensor indices should be 0,1,2 for the accelerometer,
> Gyroscope, Magnetometer respectively, but this interchanged
> possibly could be because i was using a test MP2 firmware
> on my machine.
> 
> This patch fixes the earlier commit with the right sensor
> indices and also removing unused structures
> _hid_report_descriptor,
> _hid_device_descriptor as reported by Richard.
> 
> Reported-by: Mandoli <lipheng@hanmail.net>
> Reported-by: Richard Neumann <mail@richard-neumann.de>
> Signed-off-by: Sandeep Singh <sandeep.singh@amd.com>
> Fixes: SFH: PCIe driver to add support of AMD sensor fusion hub (4f567b9f8141)

I've modified the Fixes: tag so that it has proper format and applied, 
thanks.

-- 
Jiri Kosina
SUSE Labs


      reply	other threads:[~2020-10-29 15:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28  9:00 Sandeep Singh
2020-10-29 15:03 ` Jiri Kosina [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.YFH.7.76.2010291602550.18859@cbobk.fhfr.pm \
    --to=jikos@kernel.org \
    --cc=Nehal-bakulchandra.Shah@amd.com \
    --cc=Sandeep.Singh@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jic23@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lipheng@hanmail.net \
    --cc=mail@richard-neumann.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®