From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0582C38145 for ; Wed, 7 Sep 2022 20:10:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229950AbiIGUKF (ORCPT ); Wed, 7 Sep 2022 16:10:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229632AbiIGUKC (ORCPT ); Wed, 7 Sep 2022 16:10:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08A9C3FA32; Wed, 7 Sep 2022 13:10:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2338161A2B; Wed, 7 Sep 2022 20:10:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD46AC433C1; Wed, 7 Sep 2022 20:09:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662581399; bh=tY2rZkKMAh0HGG+k/VKKFfccvfgdnJQ271Rh8HaQ56A=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=uvMp0pvg/Seeo4CI4fAPNMHhDJSFy0uoZdedZTUujyMpLAxClWKShXl0k9M/ITYF0 0i8MxAgVUKHLOmnyqJKMDMggXgmb+ojw7WgP84Si+gdLR4vLB/RbTcBBypnp9dT1ST 5NPvCWe8JRTI4UX0LlJ/gZYA5BXmGxKvvasf/GOut3xJ9HGifpp9lSKvrGPQBNBQZ4 YiKwdyLneccG5hrbaP73dkZpMEjgbvWSL5LtTFwMzLO++o/XHUbZEoIMH3f7qj2FFf /9rI5uc8vg0SAduMxV67hsktLIr9dWxLqd1A80g7JszBojJETTC46ZE0yp7WtlbO14 YjilFAmt9SbvQ== Date: Wed, 7 Sep 2022 22:09:55 +0200 (CEST) From: Jiri Kosina To: Bastien Nocera cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Benjamin Tissoires , "Peter F . Patel-Schneider" , =?ISO-8859-15?Q?Filipe_La=EDns?= , Nestor Lopez Casado Subject: Re: [v4 1/5] HID: core: Export hid_match_id() In-Reply-To: Message-ID: References: <20220830132549.7240-1-hadess@hadess.net> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 7 Sep 2022, Bastien Nocera wrote: > > Export hid_match_id() so it can be used in device-specific drivers to > > implement their own matching with open-coding a match function. > > > > Signed-off-by: Bastien Nocera > > --- > >  drivers/hid/hid-core.c | 1 + > >  1 file changed, 1 insertion(+) > > > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > > index b7f5566e338d..72f8d8835b34 100644 > > --- a/drivers/hid/hid-core.c > > +++ b/drivers/hid/hid-core.c > > @@ -2088,6 +2088,7 @@ const struct hid_device_id *hid_match_id(const > > struct hid_device *hdev, > >   > >         return NULL; > >  } > > +EXPORT_SYMBOL_GPL(hid_match_id); > >   > >  static const struct hid_device_id hid_hiddev_list[] = { > >         { HID_USB_DEVICE(USB_VENDOR_ID_MGE, USB_DEVICE_ID_MGE_UPS) }, > > If those patches look good to you, would be great to get merged. > Benjamin doesn't have the bandwidth to test the patches on his own test > hardware right now, but I've been using them daily for a week now. Alright, I was waiting for Ack from Benjamin, but based on this, and due to the fact that I don't see any issue with it myself, I've now applied the series to for-6.1/logitech branch so that it gets as much linux-next exposure as possible. Thanks, -- Jiri Kosina SUSE Labs