From: Jiri Kosina <jikos@kernel.org>
To: Qi Feng <fengqi706@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
fengqi <fengqi@xiaomi.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: Re: [PATCH] HID: add KEY_CAMERA_FOCUS event in HID
Date: Fri, 20 Jan 2023 18:51:00 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2301201849090.1734@cbobk.fhfr.pm> (raw)
In-Reply-To: <20230109123216.4974-1-fengqi706@gmail.com>
On Mon, 9 Jan 2023, Qi Feng wrote:
> From: fengqi <fengqi@xiaomi.com>
>
> Our HID device need KEY_CAMERA_FOCUS event to control camera, but this
> event is non-existent in current HID driver. So we add this event in
> hid-input.c
>
> Signed-off-by: fengqi <fengqi@xiaomi.com>
> ---
> drivers/hid/hid-input.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> index 9b59e436df0a..22cca3406b5c 100644
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -1105,6 +1105,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
> case 0x0e5: map_key_clear(KEY_BASSBOOST); break;
> case 0x0e9: map_key_clear(KEY_VOLUMEUP); break;
> case 0x0ea: map_key_clear(KEY_VOLUMEDOWN); break;
> + case 0x0ee: map_key_clear(KEY_CAMERA_FOCUS); break;
> case 0x0f5: map_key_clear(KEY_SLOW); break;
>
> case 0x181: map_key_clear(KEY_BUTTONCONFIG); break;
[ CCing Benjamin ]
Hi,
so according to HUT 1.3.0, 0xeb-0xef are Reserved for now, so I'd be a
little bit hesitatnt to but this into the generic mapping, as later HUT
revision might define this in a different way.
Which devices are known to be producing this?
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2023-01-20 17:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 12:32 Qi Feng
2023-01-10 9:53 ` qi feng
2023-01-12 2:46 ` qi feng
2023-01-20 17:51 ` Jiri Kosina [this message]
2023-01-29 2:59 ` qi feng
2023-01-30 14:28 ` Jiri Kosina
2023-02-02 9:56 ` qi feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2301201849090.1734@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=fengqi706@gmail.com \
--cc=fengqi@xiaomi.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®