From: "Adam Tlałka" <atlka@pg.gda.pl>
To: "Andrew Morton" <akpm@osdl.org>, "Jiri Slaby" <xslaby@fi.muni.cz>
Cc: linux-kernel@vger.kernel.org, greg@kroah.com
Subject: Re: [PATCH 1/4] media-radio: Pci probing for maestro radio
Date: Wed, 04 Jan 2006 10:51:57 +0100 [thread overview]
Message-ID: <op.s2ulovh1q5yxc3@merlin> (raw)
In-Reply-To: <20060104014532.3909a51e.akpm@osdl.org>
Dnia 04-01-2006 o 10:45:32 Andrew Morton <akpm@osdl.org> napisał:
> "Jiri Slaby" <xslaby@fi.muni.cz> wrote:
>>
>> + retval = video_register_device(maestro_radio_inst, VFL_TYPE_RADIO,
>> + radio_nr);
>> + if (retval) {
>> + printk(KERN_ERR "can't register video device!\n");
>> + goto errfr1;
>> + }
>> +
>> + if (!radio_power_on(radio_unit)) {
>> + retval = -EIO;
>
> Shouldn't we unregister the video device here?
Current behaviour means that device is here but not functioning properly
but
we can unregister it of course because it is useless anyway ;-).
Regards
--
Adam Tlałka mailto:atlka@pg.gda.pl ^v^ ^v^ ^v^
System & Network Administration Group ~~~~~~
Computer Center, Gdańsk University of Technology, Poland
PGP public key: finger atlka@sunrise.pg.gda.pl
next prev parent reply other threads:[~2006-01-04 9:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-31 16:16 [PATCH 0/4] maestro radio driver rewritten to 2.6 pci api Jiri Slaby
2005-12-31 16:16 ` [PATCH 2/4] media-radio: Maestro radio Lindent Jiri Slaby
2005-12-31 16:16 ` [PATCH 1/4] media-radio: Pci probing for maestro radio Jiri Slaby
2006-01-04 9:45 ` Andrew Morton
2006-01-04 9:51 ` Adam Tlałka [this message]
2006-01-04 10:22 ` [PATCH] media-radio: video device unregister in one fail case [Was: Re: [PATCH 1/4] media-radio: Pci probing for maestro radio] Jiri Slaby
2005-12-31 16:16 ` [PATCH 3/4] media-radio: Maestro types change Jiri Slaby
2005-12-31 16:16 ` [PATCH 4/4] media-radio: Maestro avoid accessing private structures directly Jiri Slaby
2005-12-31 16:36 ` [PATCH 5/4 :) I forgot] media-radio: Maestro radio delete owner line from video device Jiri Slaby
2005-12-31 16:37 ` [PATCH 0/5] maestro radio driver rewritten to 2.6 pci api Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.s2ulovh1q5yxc3@merlin \
--to=atlka@pg.gda.pl \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xslaby@fi.muni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®