From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751900Ab1LUGrb (ORCPT ); Wed, 21 Dec 2011 01:47:31 -0500 Received: from mail-ee0-f46.google.com ([74.125.83.46]:63312 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751214Ab1LUGr3 convert rfc822-to-8bit (ORCPT ); Wed, 21 Dec 2011 01:47:29 -0500 Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "Joe Perches" Cc: "Minchan Kim" , "Andrew Morton" , linux-mm , LKML Subject: Re: [PATCH] vmalloc: remove #ifdef in function body References: <1324444679-9247-1-git-send-email-minchan@kernel.org> <1324445481.20505.7.camel@joe2Laptop> <20111221054531.GB28505@barrios-laptop.redhat.com> <1324447099.21340.6.camel@joe2Laptop> <1324449156.21735.7.camel@joe2Laptop> Date: Wed, 21 Dec 2011 07:47:17 +0100 MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT From: "Michal Nazarewicz" Message-ID: In-Reply-To: <1324449156.21735.7.camel@joe2Laptop> User-Agent: Opera Mail/11.60 (Linux) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Dec 2011 07:32:36 +0100, Joe Perches wrote: > On Wed, 2011-12-21 at 07:21 +0100, Michal Nazarewicz wrote: >> it seems the community prefers >> having ifdefs outside of the function. > > Some do, some don't. > > http://comments.gmane.org/gmane.linux.network/214543 This patch that you pointed to is against “#ifdefs are ugly” style described in Documentation/SubmittingPatches. > If it's not in coding style, I suggest > it should be changed if it doesn't > add some other useful value. That my be true. I guess no one took time to adding it to the document. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +------------------ooO--(_)--Ooo--