From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756142Ab2AJMtD (ORCPT ); Tue, 10 Jan 2012 07:49:03 -0500 Received: from mail-ee0-f46.google.com ([74.125.83.46]:44506 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754377Ab2AJMtB convert rfc822-to-8bit (ORCPT ); Tue, 10 Jan 2012 07:49:01 -0500 Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "Gilad Ben-Yossef" Cc: "Christoph Lameter" , linux-kernel@vger.kernel.org, "Chris Metcalf" , "Peter Zijlstra" , "Frederic Weisbecker" , "Russell King" , linux-mm@kvack.org, "Pekka Enberg" , "Matt Mackall" , "Sasha Levin" , "Rik van Riel" , "Andi Kleen" , "Andrew Morton" , "Alexander Viro" , linux-fsdevel@vger.kernel.org, "Avi Kivity" Subject: Re: [PATCH v6 7/8] mm: only IPI CPUs to drain local pages if they exist References: <1326040026-7285-8-git-send-email-gilad@benyossef.com> Date: Tue, 10 Jan 2012 13:48:56 +0100 MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT From: "Michal Nazarewicz" Message-ID: In-Reply-To: User-Agent: Opera Mail/11.60 (Linux) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > 2012/1/9 Michal Nazarewicz : >> This is initialised in setup_per_cpu_pageset() so it needs to be file >> scoped. On Tue, 10 Jan 2012 13:43:21 +0100, Gilad Ben-Yossef wrote: > Yes. The cpumask_var_t abstraction is convenient and all but it does > make the allocation very non obvious when it does not happen in > proximity to the variable use - it doesn't *look* like a pointer. You can say that about any file scoped variable that needs non-const initialisation, not only pointers. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +------------------ooO--(_)--Ooo--