From: "Michal Nazarewicz" <mina86@mina86.com>
To: "Felipe Balbi" <balbi@ti.com>,
linux-usb@vger.kernel.org, "Thomas Faber" <thfabba@gmx.de>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadgetfs: return number of bytes on ep0 read request
Date: Fri, 02 Mar 2012 15:15:15 +0100 [thread overview]
Message-ID: <op.wajq7pvf3l0zgt@mpn-glaptop> (raw)
In-Reply-To: <4F5087CE.50304@gmx.de>
On Fri, 02 Mar 2012 09:41:50 +0100, Thomas Faber <thfabba@gmx.de> wrote:
> A read from GadgetFS endpoint 0 during the data stage of a control
> request would always return 0 on success (as returned by
> wait_event_interruptible) despite having written data into the user
> buffer.
> This patch makes it correctly set the return value to the number of
> bytes read.
>
> Signed-off-by: Thomas Faber <thfabba@gmx.de>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
Cc: stable@vger.kernel.org
> ---
> drivers/usb/gadget/inode.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/gadget/inode.c b/drivers/usb/gadget/inode.c
> index ae04266..4f18a0e 100644
> --- a/drivers/usb/gadget/inode.c
> +++ b/drivers/usb/gadget/inode.c
> @@ -1043,6 +1043,8 @@ ep0_read (struct file *fd, char __user *buf, size_t len, loff_t *ptr)
> // FIXME don't call this with the spinlock held ...
> if (copy_to_user (buf, dev->req->buf, len))
> retval = -EFAULT;
> + else
> + retval = len;
> clean_req (dev->gadget->ep0, dev->req);
> /* NOTE userspace can't yet choose to stall */
> }
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--
prev parent reply other threads:[~2012-03-02 14:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 8:41 Thomas Faber
2012-03-02 14:15 ` Michal Nazarewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.wajq7pvf3l0zgt@mpn-glaptop \
--to=mina86@mina86.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=thfabba@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®