Re: [PATCH] testusb: enable option "-l" in command line

["Michal Nazarewicz" <mina86@mina86.com>]

On Tue, 22 May 2012 03:40:28 -0700, Du, ChangbinX <changbinx.du@intel.com> wrote:
> The "-l" option which makes test function loops forever, can be used for
> usb stress test. But it is not usable yet, so enable it.

This sentence is confusing (at least to me).  How about something like:

	The testusb.c tool has support for looping forever implemented, which
	may be useful for stress test, yet it is not exposed to the user, so
	even though the code is there, it cannot be used.  This commit adds
	“l” to the set of options handled by the application which enables
	the feature.

> Also, I collate help information for each command line option to make it
> easier to use for novices.
>
> Signed-off-by: Du Changbin <changbinx.du@intel.com>

Acked-by: Michal Nazarewicz <mina86@mina86.com>

> ---
>  tools/usb/testusb.c |   21 ++++++++++++++++-----
>  1 file changed, 16 insertions(+), 5 deletions(-)
>
> diff --git a/tools/usb/testusb.c b/tools/usb/testusb.c
> index 0aac3ff..7a7adf3 100644
> --- a/tools/usb/testusb.c
> +++ b/tools/usb/testusb.c
> @@ -422,7 +422,7 @@ int main (int argc, char **argv)
>  	/* for easy use when hotplugging */
>  	device = getenv ("DEVICE");
>-	while ((c = getopt (argc, argv, "D:aA:c:g:hns:t:v:")) != EOF)
> +	while ((c = getopt (argc, argv, "D:aA:c:g:hlns:t:v:")) != EOF)
>  	switch (c) {
>  	case 'D':	/* device, if only one */
>  		device = optarg;
> @@ -465,10 +465,21 @@ int main (int argc, char **argv)
>  	case 'h':
>  	default:
>  usage:
> -		fprintf (stderr, "usage: %s [-n] [-D dev | -a | -A usbfs-dir]\n"
> -			"\t[-c iterations]  [-t testnum]\n"
> -			"\t[-s packetsize] [-g sglen] [-v vary]\n",
> -			argv [0]);
> +		fprintf (stderr,
> +			"usage: %s [options]\n"
> +			"Options:\n"
> +			"\t-D dev		only test specific device\n"
> +			"\t-A usbfs-dir\n"
> +			"\t-a		test all recognized devices\n"
> +			"\t-l		loop forever(for stress test)\n"
> +			"\t-t testnum	only run specified case\n"
> +			"\t-n		no test running, show devices to be tested\n"
> +			"Case arguments:\n"
> +			"\t-c iterations	default 1000\n"
> +			"\t-s packetsize	default 512\n"
> +			"\t-g sglen	default 32\n"
> +			"\t-v vary		default 512\n",
> +			argv[0]);
>  		return 1;
>  	}
>  	if (optind != argc)

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--