From: "Michal Nazarewicz" <mpn@google.com>
To: "Alan Stern" <stern@rowland.harvard.edu>
Cc: "Felipe Balbi" <balbi@ti.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] usb: gadget: mass_storage: require backing file for non-removable LUNs
Date: Mon, 18 Jun 2012 17:32:21 +0200 [thread overview]
Message-ID: <op.wf3ur7dppw9a85@mpn-glaptop> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1206181016320.1591-100000@iolanthe.rowland.org>
On Mon, 18 Jun 2012 16:18:41 +0200, Alan Stern <stern@rowland.harvard.edu> wrote:
> On Mon, 18 Jun 2012, Michal Nazarewicz wrote:
>
>> From: Michal Nazarewicz <mina86@mina86.com>
>>
>> The fsg_file_store() function does not check whether a LUN is removable or not
>> allowing one to specify an empty file name for a non-removable LUN. This
>> commit adds explicit check of whether a file name is provided for
>> non-removable LUNs.
>
> Looks okay. Note that in file_storage.c, the "file" attribute isn't
> writable if the LUN isn't removable, and the "ro" attribute isn't
> writable if the LUN is a cdrom. Maybe you would prefer to do things
> that way instead.
Makes sense, I'll rewrite this patch to do that.
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--
next prev parent reply other threads:[~2012-06-18 15:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 12:37 [PATCH 0/3] A few mass_storage fixes Michal Nazarewicz
2012-06-18 12:37 ` [PATCH 1/3] usb: gadget: storage_common: remove FSG_BUFFHD_STATIC_BUFFER support Michal Nazarewicz
2012-06-18 12:37 ` [PATCH 2/3] usb: gadget: mass_storage: fail fsg_store_file() early if colud not open file Michal Nazarewicz
2012-06-18 14:20 ` Alan Stern
2012-06-18 12:37 ` [PATCH 3/3] usb: gadget: mass_storage: require backing file for non-removable LUNs Michal Nazarewicz
2012-06-18 14:18 ` Alan Stern
2012-06-18 15:32 ` Michal Nazarewicz [this message]
2012-06-19 11:12 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.wf3ur7dppw9a85@mpn-glaptop \
--to=mpn@google.com \
--cc=balbi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome