From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756056Ab2GCMyS (ORCPT ); Tue, 3 Jul 2012 08:54:18 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:50547 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751177Ab2GCMyQ convert rfc822-to-8bit (ORCPT ); Tue, 3 Jul 2012 08:54:16 -0400 Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "Marek Szyprowski" , "Barry Song" <21cnbao@gmail.com> Cc: "Barry Song" , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, workgroup.linux@csr.com, "Barry Song" Subject: Re: [PATCH v4] mm: cma: add a simple kernel module as the helper to test CMA References: <1331120259-30780-1-git-send-email-Barry.Song@csr.com> <03e601cd58ec$5b8177b0$12846710$%szyprowski@samsung.com> Date: Tue, 03 Jul 2012 14:54:12 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT From: "Michal Nazarewicz" Message-ID: In-Reply-To: User-Agent: Opera Mail/12.01 (Linux) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > 2012/7/3 Marek Szyprowski : >> IMHO the right place for such code is in drivers/misc instead of tools/cma. >> >> This patch contains a kernel module source code so it should be put with other kernel >> modules. tools/ directory is aimed to contain user space code useful for developing and >> testing Linux kernel. On Tue, 03 Jul 2012 09:39:34 +0200, Barry Song <21cnbao@gmail.com> wrote: > this one is aiming to test CMA, it should be in tools/ as Michal > Nazarewicz and i have talked about that. > it is not a real driver at all. Yeah, I feel like it's better placed in tools/ not to pollute other directories with drivers that are of no use to regular users. I don't have strong feelings about it though, so I'm fine either way. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +------------------ooO--(_)--Ooo--