From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751901AbdK1Ivd convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Nov 2017 03:51:33 -0500
Received: from mga05.intel.com ([192.55.52.43]:37991 "EHLO mga05.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751451AbdK1Ivc (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Nov 2017 03:51:32 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.44,467,1505804400"; 
   d="scan'208";a="6975704"
Content-Type: text/plain; charset=iso-8859-15; format=flowed; delsp=yes
To: linux-doc@vger.kernel.org,
        =?iso-8859-15?Q?Jonathan_Neusch=E4fer?= <j.neuschaefer@gmx.net>
Cc: "Jani Nikula" <jani.nikula@linux.intel.com>,
        "Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
        "Rodrigo Vivi" <rodrigo.vivi@intel.com>,
        "Daniel Vetter" <daniel.vetter@intel.com>,
        "Sean Paul" <seanpaul@chromium.org>, "David Airlie" <airlied@linux.ie>,
        "Jonathan Corbet" <corbet@lwn.net>, intel-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        =?iso-8859-15?Q?Ville_Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915/guc: Fix doc reference to intel_guc_fw.c
References: <20171128065052.23930-1-j.neuschaefer@gmx.net>
Date: Tue, 28 Nov 2017 09:51:13 +0100
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
From: "Michal Wajdeczko" <michal.wajdeczko@intel.com>
Message-ID: <op.zaen7nglxaggs7@mwajdecz-mobl1.ger.corp.intel.com>
In-Reply-To: <20171128065052.23930-1-j.neuschaefer@gmx.net>
User-Agent: Opera Mail/1.0 (Win32)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 28 Nov 2017 07:50:52 +0100, Jonathan Neuschäfer  
<j.neuschaefer@gmx.net> wrote:

> Sphinx complains that it can't find intel_guc_loader.c, and rightly so:
> The file has been renamed.
>
> Fixes: e8668bbcb0f9 ("drm/i915/guc: Rename intel_guc_loader.c to  
> intel_guc_fw.c")
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> ---
>  Documentation/gpu/i915.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/gpu/i915.rst b/Documentation/gpu/i915.rst
> index 2e7ee0313c1c..e21698e16534 100644
> --- a/Documentation/gpu/i915.rst
> +++ b/Documentation/gpu/i915.rst
> @@ -341,10 +341,10 @@ GuC
>  GuC-specific firmware loader
>  ----------------------------
> -.. kernel-doc:: drivers/gpu/drm/i915/intel_guc_loader.c
> +.. kernel-doc:: drivers/gpu/drm/i915/intel_guc_fw.c
>     :doc: GuC-specific firmware loader
> -.. kernel-doc:: drivers/gpu/drm/i915/intel_guc_loader.c
> +.. kernel-doc:: drivers/gpu/drm/i915/intel_guc_fw.c
>     :internal:
> GuC-based command submission

+ Ville

Well, this will fix sphinx error, but in my opinion it will not make
i915 documentation any better. See my earlier patch/comments in [1].
So maybe better to wait for other comments which way to go.

Thanks for the patch,
Michal

[1] https://patchwork.freedesktop.org/patch/188424/