mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexandre Oliva <aoliva@redhat.com>
To: Arjan van de Ven <arjanv@redhat.com>
Cc: Adrian Bunk <bunk@fs.tum.de>, Jakub Jelinek <jakub@redhat.com>,
	Nigel Cunningham <ncunningham@linuxmail.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: GCC 3.4 and broken inlining.
Date: 10 Jul 2004 18:17:29 -0300	[thread overview]
Message-ID: <or7jtbpno6.fsf@livre.redhat.lsd.ic.unicamp.br> (raw)
In-Reply-To: <20040708210925.GA13908@devserv.devel.redhat.com>

On Jul  8, 2004, Arjan van de Ven <arjanv@redhat.com> wrote:

> the problem I've seen is that when gcc doesn't honor normal inline, it will
> often error out if you always inline....

Because the always_inline was designed to mark functions that *must*
be inlined otherwise the program breaks (e.g., early dynamic loader
code where you still can't do function calls), not as an
`I'd-really-like-this-to-be-inlined-dammit' flag.

We could add another attribute/keyword/whatever to give a stronger
inline hint, but that would still leave room for the compiler to
decide it can't inline the function for whatever reason.  So you have
to know what to demand from the compiler:
inline-or-fail-because-there's-no-point-otherwise (attribute
always_inline) or inline-if-it-makes-the-program-faster (inline
keyword).  The latter is obviously based on heuristics, so it
sometimes gets things wrong, especially when inlining would enable a
lot of simplification that the compiler can't foresee without actually
doing the work and somehow backtracking if it turns out to not be
profitable (which would still be a guess).

-- 
Alexandre Oliva             http://www.ic.unicamp.br/~oliva/
Red Hat Compiler Engineer   aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist  oliva@{lsd.ic.unicamp.br, gnu.org}

  parent reply	other threads:[~2004-07-10 21:18 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-08 11:46 Nigel Cunningham
2004-07-08 12:07 ` Jakub Jelinek
2004-07-08 12:11   ` Nigel Cunningham
     [not found]     ` <200407090036.39323.vda@port.imtp.ilyichevsk.odessa.ua>
2004-07-08 22:00       ` Nigel Cunningham
2004-07-08 22:41         ` Zan Lynx
2004-07-09  6:54           ` Arjan van de Ven
2004-07-10 21:20             ` Alexandre Oliva
2004-07-08 20:52   ` Adrian Bunk
2004-07-08 21:09     ` Arjan van de Ven
2004-07-08 22:08       ` Nigel Cunningham
2004-07-08 22:25         ` Adrian Bunk
2004-07-08 22:37           ` Nigel Cunningham
2004-07-09  6:24         ` Arjan van de Ven
2004-07-10  1:21           ` Adrian Bunk
2004-07-10  2:30             ` William Lee Irwin III
2004-07-13 22:19               ` Timothy Miller
2004-07-10  6:31             ` Arjan van de Ven
2004-07-08 22:16       ` [2.6 patch] " Adrian Bunk
2004-07-10 21:17       ` Alexandre Oliva [this message]
     [not found] <2fFzK-3Zz-23@gated-at.bofh.it>
     [not found] ` <2fG2F-4qK-3@gated-at.bofh.it>
     [not found]   ` <2fG2G-4qK-9@gated-at.bofh.it>
     [not found]     ` <2fPfF-2Dv-21@gated-at.bofh.it>
     [not found]       ` <2fPfF-2Dv-19@gated-at.bofh.it>
2004-07-09  4:51         ` Andi Kleen
2004-07-09  4:56           ` Nigel Cunningham
2004-07-09  5:46             ` Andi Kleen
2004-07-09  9:43               ` Michael Buesch
2004-07-09 10:23                 ` Paweł Sikora
2004-07-10 21:33             ` Alexandre Oliva
2004-07-11  5:52               ` Andi Kleen
2004-07-14  3:00                 ` Alexandre Oliva
2004-07-09 18:40           ` Adrian Bunk
2004-07-09 21:54             ` Andi Kleen
2004-07-09 22:17               ` Adrian Bunk
2004-07-10  4:50                 ` Andi Kleen
2004-07-10 21:25           ` Alexandre Oliva
2004-07-11  5:53             ` Andi Kleen
2004-07-11  6:55               ` Andrew Morton
2004-07-11  8:26                 ` Andi Kleen
2004-07-11  8:32                   ` Andrew Morton
2004-07-11  9:08                     ` Andi Kleen
2004-07-11 11:50                     ` Adrian Bunk
2004-07-11 13:01                       ` Arnd Bergmann
     [not found] <2fVEt-6Vy-11@gated-at.bofh.it>
     [not found] ` <2fVO5-79H-3@gated-at.bofh.it>
     [not found]   ` <2fWqQ-7uv-19@gated-at.bofh.it>
     [not found]     ` <2g0b6-1Cf-23@gated-at.bofh.it>
2004-07-09 10:04       ` Andi Kleen
     [not found] <fa.hnj36kg.4no2jk@ifi.uio.no>
     [not found] ` <fa.gktbdsg.1n4em8o@ifi.uio.no>
2004-07-10  3:12   ` Robert Hancock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=or7jtbpno6.fsf@livre.redhat.lsd.ic.unicamp.br \
    --to=aoliva@redhat.com \
    --cc=arjanv@redhat.com \
    --cc=bunk@fs.tum.de \
    --cc=jakub@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ncunningham@linuxmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®