From: Andi Kleen <ak@suse.de>
To: Ingo Rohloff <rohloff@in.tum.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Loop encryption module locking bug (linux-2.4.5).
Date: 21 Jun 2001 14:36:58 +0200 [thread overview]
Message-ID: <ouppubyxb4l.fsf@pigdrop.muc.suse.de> (raw)
In-Reply-To: <20010621135043.A13107@lxmayr6.informatik.tu-muenchen.de.suse.lists.linux.kernel>
In-Reply-To: Ingo Rohloff's message of "21 Jun 2001 13:55:33 +0200"
<sarcasm>
I think your mail is offtopic for linux-kernel: it doesn't mention Microsoft or user space
java programming or pointer to random unrelated web pages, but an actual kernel bug.
</sarcasm>
Ingo Rohloff <rohloff@in.tum.de> writes:
>
> If lo_open doesn't call the cipher lock function and
> lo_release doesn't call the cipher unlock function, the issue
> is resolved. (So code gets deleted in the patch.)
I think it would be better if the low level module stays locked also while the
control fd is open. That would match the semantics of most other devices.
Right fix probably is to call ->lock twice in loop_set_status()
[Also the locking is not SMP safe, but that's a different issue, for the e.g. ->lock
would need to be replaced with a struct module *owner and also some other locking]
-Andi
next parent reply other threads:[~2001-06-21 12:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20010621135043.A13107@lxmayr6.informatik.tu-muenchen.de.suse.lists.linux.kernel>
2001-06-21 12:36 ` Andi Kleen [this message]
[not found] ` <3B333180.A804582F@pp.inet.fi>
[not found] ` <20010622135942.A1591@gruyere.muc.suse.de>
2001-06-22 15:08 ` Ingo Rohloff
2001-06-21 11:50 Ingo Rohloff
2001-06-21 18:19 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ouppubyxb4l.fsf@pigdrop.muc.suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rohloff@in.tum.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®