Re: ioctl arg passing

[Jonathan Lundell <jlundell@pobox.com>]

At 11:09 PM +0100 4/23/01, Matt wrote:
>| struct instruction_t {
>|	__s16 code;
>|	__s16 rxlen;
>|	__s16 *rxbuf;
>|	__s16 txlen;
>|	__s16 *txbuf;
>| };
>
>So far, I now know I can grab stuff across the user <-> kernel divide as I
>planned. The only problem I'm left with, which was kindly pointed out to
>me, is a question of packing with respect to both kernel & user-space.
>
>Can anyone suggest a method of either assuring the above structure is
>always packed the same, or alterations so that the problem is
>minimised? Either splitting the one ioctl into many, etc.

struct instruction_t {
	__s16 code;
	__s16 rxlen;
	__s16 txlen;
	__s16 pad;
	__s16 *rxbuf;
	__s16 *txbuf;
};

This was it's always aligned and packed, regardless of compiler packing settings. This particular layout happens to work with 64-bit pointers as well.... (I'm assuming that __s16 is a signed 16-bit type).

You can move the pointers to the front, but it's not necessary in this case, so I tried to preserve some of your original ordering (code first, rx before tx).
-- 
/Jonathan Lundell.