From: Jonathan Lundell <jlundell@pobox.com>
To: Matthew Wilcox <matthew@wil.cx>, Alexander Viro <viro@math.psu.edu>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [Final call for testers][PATCH] superblock handling changes (2.4.6-pre3)
Date: Fri, 15 Jun 2001 10:02:55 -0700 [thread overview]
Message-ID: <p0510030cb74fef8a9b2a@[207.213.214.37]> (raw)
In-Reply-To: <20010615171632.C9522@parcelfarce.linux.theplanet.co.uk>
In-Reply-To: <Pine.GSO.4.21.0106130044390.942-100000@weyl.math.psu.edu> <Pine.GSO.4.21.0106150100210.7244-100000@weyl.math.psu.edu> <20010615171632.C9522@parcelfarce.linux.theplanet.co.uk>
At 5:16 PM +0100 2001-06-15, Matthew Wilcox wrote:
>I think this could be clearer.
>
> struct list_head *tmp;
>restart:
> spin_lock(&sb_lock);
> list_for_each(tmp, super_blocks) {
> struct super_block *sb = sb_entry(tmp);
> if (!sb->s_dirt)
> continue;
> spin_unlock(&sb_lock);
> down_read(&sb->s_umount);
> write_super(sb);
> drop_super(sb);
> goto restart;
> }
> spin_unlock(&sb_lock);
A minor improvement, IMO, is:
struct list_head *tmp;
restart:
spin_lock(&sb_lock);
list_for_each(tmp, super_blocks) {
struct super_block *sb = sb_entry(tmp);
if (sb->s_dirt) {
sb->s_count++;
spin_unlock(&sb_lock);
down_read(&sb->s_umount);
write_super(sb);
drop_super(sb);
goto restart;
}
}
spin_unlock(&sb_lock);
--
/Jonathan Lundell.
prev parent reply other threads:[~2001-06-15 17:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-12 4:29 [CFT][PATCH] superblock handling changes Alexander Viro
2001-06-12 3:22 ` Marcelo Tosatti
2001-06-12 5:17 ` Alexander Viro
2001-06-12 6:38 ` George Bonser
2001-06-13 4:50 ` [CFT][PATCH] superblock handling changes (2.4.6-pre3) Alexander Viro
2001-06-15 5:10 ` [Final call for testers][PATCH] " Alexander Viro
2001-06-15 16:16 ` Matthew Wilcox
2001-06-15 16:34 ` Alexander Viro
2001-06-15 16:41 ` Alexander Viro
2001-06-15 16:49 ` Matthew Wilcox
2001-06-15 19:12 ` Linus Torvalds
2001-06-15 19:18 ` Alexander Viro
2001-06-15 17:02 ` Jonathan Lundell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='p0510030cb74fef8a9b2a@[207.213.214.37]' \
--to=jlundell@pobox.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®